Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(koperator): Update chart version, pass version into deployment #1552

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Sep 7, 2023

What problem does this PR solve?:

  • updates operator helm chart version to be in line with dkp version
  • pass chart version into deployment args
  • set kommandercore spec version to chart version in post-install

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-97955

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 7, 2023
@gracedo gracedo self-assigned this Sep 7, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 7, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@gracedo gracedo marked this pull request as ready for review September 7, 2023 04:09
@gracedo gracedo requested a review from a team September 7, 2023 04:27
@gracedo gracedo merged commit 3f3242c into main Sep 7, 2023
21 checks passed
@gracedo gracedo deleted the gracedo/koperator_D2IQ-97955 branch September 7, 2023 17:23
gracedo added a commit that referenced this pull request Sep 8, 2023
gracedo added a commit that referenced this pull request Sep 13, 2023
gracedo added a commit that referenced this pull request Sep 13, 2023
gracedo added a commit that referenced this pull request Sep 18, 2023
* Revert "feat(koperator): Update chart version, pass version into deployment (#1552)"

This reverts commit 3f3242c.

* feat(koperator): Bump chart version

* refactor(koperator): User server side apply for kubectl apply kcore

* feat(koperator): Add events create rule

* feat(koperator): Bump HR version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants