Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disables loki telemetry #1571

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix: disables loki telemetry #1571

merged 2 commits into from
Sep 11, 2023

Conversation

tillt
Copy link
Contributor

@tillt tillt commented Sep 11, 2023

What problem does this PR solve?:
Disables loki telemetry.

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-99148

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

disables loki telemetry

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@tillt tillt added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off auto-backport services/grafana-loki labels Sep 11, 2023
@tillt tillt self-assigned this Sep 11, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 11, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Sep 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6148661269

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%
Totals Coverage Status
Change from base Build 6147841331: 0.0%
Covered Lines: 136
Relevant Lines: 171
💛 - Coveralls

msdolbey
msdolbey approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Fix it Fix it

@tillt tillt added the bug Something isn't working label Sep 11, 2023
@tillt tillt requested a review from cbuto September 11, 2023 15:42
cbuto
cbuto approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@cbuto cbuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@tillt tillt enabled auto-merge (squash) September 11, 2023 15:49
@tillt tillt merged commit 4e1a200 into main Sep 11, 2023
33 checks passed
@tillt tillt deleted the till/loki-telemetry-fix branch September 11, 2023 16:30
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@tillt
fix: disables loki telemetry (#1571)
6f9bd04 
* fix: disables loki telemetry

* fix: additional loki instance

(cherry picked from commit 4e1a200)
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@tillt
fix: disables loki telemetry (#1571)
d3fd8b1 
* fix: disables loki telemetry

* fix: additional loki instance

(cherry picked from commit 4e1a200)
@github-actions github-actions bot mentioned this pull request Sep 11, 2023
Merged
@github-actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ release-2.4
✅ release-2.5
✅ release-2.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Sep 11, 2023
@tillt
fix: disables loki telemetry (#1571)
ecdd1b6 
* fix: disables loki telemetry

* fix: additional loki instance

(cherry picked from commit 4e1a200)
cwyl02 pushed a commit that referenced this pull request Sep 11, 2023
@github-actions @tillt @cbuto
fix: disables loki telemetry (2.5) (#1574)
f4121b1 
* fix: disables loki telemetry (#1571)

* fix: disables loki telemetry

* fix: additional loki instance

(cherry picked from commit 4e1a200)

* chore: bump Loki versions

---------

Co-authored-by: Till Toenshoff <toenshoff@me.com>
Co-authored-by: Casey Buto <cbuto@d2iq.com>
cbuto added a commit that referenced this pull request Sep 12, 2023
@github-actions @tillt @cbuto
fix: disables loki telemetry (2.4) (#1573)
00e173b 
* fix: disables loki telemetry (#1571)

* fix: disables loki telemetry

* fix: additional loki instance

(cherry picked from commit 4e1a200)

* chore: bump Loki versions

---------

Co-authored-by: Till Toenshoff <toenshoff@me.com>
Co-authored-by: Casey Buto <cbuto@d2iq.com>
cbuto added a commit that referenced this pull request Sep 14, 2023
@github-actions @tillt @cbuto
fix: disables loki telemetry (2.6) (#1575)
603e608 
* fix: disables loki telemetry (#1571)

* fix: disables loki telemetry

* fix: additional loki instance

(cherry picked from commit 4e1a200)

* chore: bump Loki versions

---------

Co-authored-by: Till Toenshoff <toenshoff@me.com>
Co-authored-by: Casey Buto <cbuto@d2iq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msdolbey msdolbey msdolbey approved these changes

@cbuto cbuto cbuto approved these changes

@jimmidyson jimmidyson Awaiting requested review from jimmidyson

@gracedo gracedo Awaiting requested review from gracedo

Assignees

@tillt tillt

Labels
auto-backport backport-to-release-2.4 backport-to-release-2.5 backport-to-release-2.6 bug Something isn't working ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/grafana-loki services/project-grafana-loki size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tillt @d2iq-mergebot @coveralls @msdolbey @cbuto