Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(test): Bump k8s to 1.27.6 #1579

Closed
wants to merge 2 commits into from
Closed

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Sep 12, 2023

What problem does this PR solve?:
update e2e tests with k8s 1.27

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-98552

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 12, 2023
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 12, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Sep 12, 2023

Pull Request Test Coverage Report for Build 6436355076

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6433717873: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@gracedo gracedo changed the title ci(test): Bump k8s to 1.27.4 ci(test): Bump k8s to 1.27.5 Sep 12, 2023
@gracedo gracedo force-pushed the gracedo/k8s1274_D2IQ-98552 branch 3 times, most recently from bace899 to a33eaaa Compare September 14, 2023 02:09
@gracedo gracedo changed the title ci(test): Bump k8s to 1.27.5 ci(test): Bump k8s to 1.27.6 Oct 12, 2023
@gracedo
Copy link
Contributor Author

gracedo commented Oct 19, 2023

I propose to close this PR and punt on upgrading k8s for this e2e test. We can wait for app specific testing, and till then, rely on our kommander and nightly test suites.

https://d2iq.atlassian.net/browse/D2IQ-98552?focusedCommentId=566427

This needs to be revisited. The two “hacked together” e2e tests are copied directly from the e2e repo and are run in TC. We decided not to migrate them to GHA due to this being a public repo and the logs of these runs would be available to GH users.

Bumping k8s would cause these 2 e2e tests running in TC to fail. But I think since these are currently the only tests in k-apps, the k8s bump only affects these two tests anyways, so we might want to just leave it like this for now (running previous k8s version) and wait for k-apps specific testing EDI to bring in proper tests. This is probably acceptable for now because we will have kommander and nightly tests running on l8s that should catch any incompatible apps.

@gracedo gracedo closed this Oct 19, 2023
@gracedo gracedo deleted the gracedo/k8s1274_D2IQ-98552 branch October 19, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants