Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ai-navigator): set proper resource limits and requests #1585

Merged

Conversation

mstruebing
Copy link
Contributor

What problem does this PR solve?:

I've ran 25 bot users which are constantly asking questions against the
service on the daily and it was inside the limits with a good margin.
It never went above 0.008 CPU usage and memory wasn't really much
affected, it stayed <30MB observed in our Grafana Dashboard.

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-99125

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

I've ran 25 bot users which are constantly asking questions against the
service on the daily and it was inside the limits with a good margin.
It never went above 0.008 CPU usage and memory wasn't really much
affected, it stayed <30MB observed in our Grafana Dashboard.

* Closes D2IQ-99125
@mstruebing mstruebing added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off needs-backport Needs to be backported to a release branch labels Sep 13, 2023
@mstruebing mstruebing self-assigned this Sep 13, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. services/ai-navigator-app labels Sep 13, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Sep 13, 2023

Pull Request Test Coverage Report for Build 6183341991

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6179903063: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@mstruebing mstruebing force-pushed the mstruebing/feat/D2IQ-991250-ai-navigator-resource-limits branch from d337226 to cf5af84 Compare September 14, 2023 09:10
@mstruebing mstruebing enabled auto-merge (squash) September 14, 2023 14:52
@mstruebing mstruebing merged commit d97ee74 into main Sep 14, 2023
12 checks passed
@mstruebing mstruebing deleted the mstruebing/feat/D2IQ-991250-ai-navigator-resource-limits branch September 14, 2023 14:54
@github-actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
release-2.6

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

github-actions bot pushed a commit that referenced this pull request Sep 14, 2023
* fix: remove empty config map

* feat(ai-navigator): set proper resource limits and requests

I've ran 25 bot users which are constantly asking questions against the
service on the daily and it was inside the limits with a good margin.
It never went above 0.008 CPU usage and memory wasn't really much
affected, it stayed <30MB observed in our Grafana Dashboard.

* Closes D2IQ-99125

* chore: set limits == requests

(cherry picked from commit d97ee74)
mstruebing added a commit that referenced this pull request Sep 14, 2023
* fix: remove empty config map

* feat(ai-navigator): set proper resource limits and requests

I've ran 25 bot users which are constantly asking questions against the
service on the daily and it was inside the limits with a good margin.
It never went above 0.008 CPU usage and memory wasn't really much
affected, it stayed <30MB observed in our Grafana Dashboard.

* Closes D2IQ-99125

* chore: set limits == requests

(cherry picked from commit d97ee74)
mstruebing added a commit that referenced this pull request Sep 14, 2023
…ests (#1585) (#1597)

feat(ai-navigator): set proper resource limits and requests (#1585)

* fix: remove empty config map

* feat(ai-navigator): set proper resource limits and requests

I've ran 25 bot users which are constantly asking questions against the
service on the daily and it was inside the limits with a good margin.
It never went above 0.008 CPU usage and memory wasn't really much
affected, it stayed <30MB observed in our Grafana Dashboard.

* Closes D2IQ-99125

* chore: set limits == requests

(cherry picked from commit d97ee74)

Co-authored-by: Max Strübing <mxstrbng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-to-release-2.6 needs-backport Needs to be backported to a release branch ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/ai-navigator-app size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants