feat(ai-navigator): set proper resource limits and requests #1585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've ran 25 bot users which are constantly asking questions against the service on the daily and it was inside the limits with a good margin. It never went above 0.008 CPU usage and memory wasn't really much affected, it stayed <30MB observed in our Grafana Dashboard. * Closes D2IQ-99125
mstruebing
added
ready-for-review
ok-to-test
github-actions
bot
added
size/S
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 6183341991
💛 - Coveralls |
cbuto
reviewed
Sep 13, 2023
mstruebing
force-pushed
the
mstruebing/feat/D2IQ-991250-ai-navigator-resource-limits
branch
from
d337226
to
cf5af84
Compare
mikolajb
approved these changes
Sep 14, 2023
cbuto
approved these changes
Sep 14, 2023
mstruebing
deleted the
mstruebing/feat/D2IQ-991250-ai-navigator-resource-limits
branch
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 14, 2023
* fix: remove empty config map * feat(ai-navigator): set proper resource limits and requests I've ran 25 bot users which are constantly asking questions against the service on the daily and it was inside the limits with a good margin. It never went above 0.008 CPU usage and memory wasn't really much affected, it stayed <30MB observed in our Grafana Dashboard. * Closes D2IQ-99125 * chore: set limits == requests (cherry picked from commit d97ee74)
mstruebing
added a commit
that referenced
this pull request
Sep 14, 2023
* fix: remove empty config map * feat(ai-navigator): set proper resource limits and requests I've ran 25 bot users which are constantly asking questions against the service on the daily and it was inside the limits with a good margin. It never went above 0.008 CPU usage and memory wasn't really much affected, it stayed <30MB observed in our Grafana Dashboard. * Closes D2IQ-99125 * chore: set limits == requests (cherry picked from commit d97ee74)
mstruebing
added a commit
that referenced
this pull request
Sep 14, 2023
…ests (#1585) (#1597) feat(ai-navigator): set proper resource limits and requests (#1585) * fix: remove empty config map * feat(ai-navigator): set proper resource limits and requests I've ran 25 bot users which are constantly asking questions against the service on the daily and it was inside the limits with a good margin. It never went above 0.008 CPU usage and memory wasn't really much affected, it stayed <30MB observed in our Grafana Dashboard. * Closes D2IQ-99125 * chore: set limits == requests (cherry picked from commit d97ee74) Co-authored-by: Max Strübing <mxstrbng@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
I've ran 25 bot users which are constantly asking questions against the
service on the daily and it was inside the limits with a good margin.
It never went above 0.008 CPU usage and memory wasn't really much
affected, it stayed <30MB observed in our Grafana Dashboard.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-99125
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist