Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: trigger release workflow after creating dev tag #1610

Merged
merged 3 commits into from
Sep 21, 2023
Merged

Conversation

cbuto
Copy link
Contributor

@cbuto cbuto commented Sep 20, 2023

What problem does this PR solve?:
Releases aren't being triggered when we create tags. this option allows us to use the built in github token and just use a workflow dispatch to do the release. alternatively, using a PAT should also work.

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Sep 20, 2023

Pull Request Test Coverage Report for Build 6262753345

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6252572614: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@cbuto cbuto force-pushed the cbuto/fix-dev-tag branch 2 times, most recently from c7af536 to 1167b59 Compare September 20, 2023 16:38
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@cbuto cbuto force-pushed the cbuto/fix-dev-tag branch 4 times, most recently from 855bd3b to ea0fd6d Compare September 20, 2023 17:54
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 20, 2023
@cbuto cbuto changed the title ci: use ci token instead of repo token for pushing tags ci: trigger release workflow after creating dev tag Sep 20, 2023
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 20, 2023
@cbuto cbuto marked this pull request as ready for review September 20, 2023 19:10
@cbuto cbuto requested a review from a team September 20, 2023 19:10
@cbuto cbuto self-assigned this Sep 20, 2023
@jimmidyson
Copy link
Contributor

I think you can get rid of most of the existing git config stuff in there btw

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@cbuto
Copy link
Contributor Author

cbuto commented Sep 20, 2023

I think you can get rid of most of the existing git config stuff in there btw

I tried getting rid of the git user config and it complained: https://github.com/mesosphere/kommander-applications/actions/runs/6253295944/job/16978375666

i was able to get rid of the private repo config step though

@mikolajb mikolajb added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Sep 21, 2023
@cbuto
Copy link
Contributor Author

cbuto commented Sep 21, 2023

requires #1613 #1614 #1615

@cbuto cbuto enabled auto-merge (squash) September 21, 2023 14:45
@cbuto cbuto merged commit 3b07ba9 into main Sep 21, 2023
12 of 16 checks passed
@cbuto cbuto deleted the cbuto/fix-dev-tag branch September 21, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants