fix: used dedicated clusterrole for kcore hooks #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwyl02
added
ready-for-review
ok-to-test
github-actions
bot
added
the
size/M
|
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
cwyl02
force-pushed
the
ychen/clusterrole-kcore
branch
from
91a2dfa
to
ba63db9
Compare
palexster
approved these changes
Sep 26, 2023
cbuto
approved these changes
Sep 26, 2023
cwyl02
force-pushed
the
ychen/clusterrole-kcore
branch
from
52a5b8c
to
e9e95e1
Compare
Pull Request Test Coverage Report for Build 6314939967
💛 - Coveralls |
gracedo
approved these changes
Oct 4, 2023
gracedo
added a commit
that referenced
this pull request
Oct 19, 2023
* Revert "fix: used dedicated clusterrole for kcore hooks (#1635)" This reverts commit 6d2c1f3. * Revert "feat: patch kcore status to kommander ver pre upgrade (#1608)" This reverts commit 585e249. * fix: use dedicated clusterrole for kcore hooks * chore: add patch & update for post install job --------- Co-authored-by: York Chen <ychen@d2iq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1608
What problem does this PR solve?:
the kommandercore related jobs have been using cluster-admin clusterrole. although it's short lived, it's better to just drop that usage.
Which issue(s) does this PR fix?:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist