-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: provision kind clusters #1653
Conversation
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 6467196206
💛 - Coveralls |
17600d8
to
246d5af
Compare
const defaultClusterName = "kind" | ||
|
||
// CreateCluster creates a new kind cluster with the given name. | ||
func CreateCluster(ctx context.Context, name string) (*Cluster, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we split the instance creation of the cluster and the actual cluster creation as we did on K-E2E. This has the advantage of validating the inputs before creating the cluster. It also has a more consistent set of methods (the object has the delete but not the create).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating Clusters in K-E2E is meant to be more flexible, but in this case, there is no input other than the cluster name
to validate. We should keep it as simple as it is, and expand on it when necessary. What do you think?
1417f58
to
adb7f0d
Compare
adb7f0d
to
b819cbb
Compare
What problem does this PR solve?:
This PR provides the minimal required functionality for creating kind clusters, which are needed for application-specific testing.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98659
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist