Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provision kind clusters #1653

Merged
merged 1 commit into from
Oct 10, 2023
Merged

feat: provision kind clusters #1653

merged 1 commit into from
Oct 10, 2023

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Oct 5, 2023

What problem does this PR solve?:
This PR provides the minimal required functionality for creating kind clusters, which are needed for application-specific testing.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98659

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@Azhovan Azhovan self-assigned this Oct 5, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 5, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@Azhovan Azhovan requested a review from a team October 5, 2023 11:38
@coveralls
Copy link

coveralls commented Oct 5, 2023

Pull Request Test Coverage Report for Build 6467196206

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6459214337: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@Azhovan Azhovan force-pushed the jabar/provision-kind-clusters branch 4 times, most recently from 17600d8 to 246d5af Compare October 9, 2023 11:12
const defaultClusterName = "kind"

// CreateCluster creates a new kind cluster with the given name.
func CreateCluster(ctx context.Context, name string) (*Cluster, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we split the instance creation of the cluster and the actual cluster creation as we did on K-E2E. This has the advantage of validating the inputs before creating the cluster. It also has a more consistent set of methods (the object has the delete but not the create).

Copy link
Contributor Author

@Azhovan Azhovan Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating Clusters in K-E2E is meant to be more flexible, but in this case, there is no input other than the cluster name to validate. We should keep it as simple as it is, and expand on it when necessary. What do you think?

@Azhovan Azhovan force-pushed the jabar/provision-kind-clusters branch 2 times, most recently from 1417f58 to adb7f0d Compare October 10, 2023 08:50
@github-actions github-actions bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 10, 2023
@Azhovan Azhovan force-pushed the jabar/provision-kind-clusters branch from adb7f0d to b819cbb Compare October 10, 2023 09:12
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 10, 2023
@Azhovan Azhovan merged commit b5d08e5 into main Oct 10, 2023
9 checks passed
@Azhovan Azhovan deleted the jabar/provision-kind-clusters branch October 10, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants