-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ensure base repositories are applied to cluster #1669
Conversation
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 8453145822Details
💛 - Coveralls |
e7e1bf8
to
8ea16fd
Compare
8ea16fd
to
d0b9dba
Compare
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
d0b9dba
to
e6f729a
Compare
What problem does this PR solve?:
This PR fixes a bug that happens when common/base repositories are applied as part of the environment setup for testing the app. The bug was caused by using yaml.Decoder() incorrectly, which only decoded one resource.
I have also set a
logger
before using kubernetes generic client, which is required for using generic kubernetes clientWhich issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98659
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist