Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ensure base repositories are applied to cluster #1669

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Oct 13, 2023

What problem does this PR solve?:
This PR fixes a bug that happens when common/base repositories are applied as part of the environment setup for testing the app. The bug was caused by using yaml.Decoder() incorrectly, which only decoded one resource.
I have also set a logger before using kubernetes generic client, which is required for using generic kubernetes client

Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-98659

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@Azhovan Azhovan requested a review from a team October 13, 2023 20:42
@Azhovan Azhovan self-assigned this Oct 13, 2023
@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 13, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Oct 13, 2023

Pull Request Test Coverage Report for Build 8453145822

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 8388479999: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@Azhovan Azhovan changed the title feat: iterate over common/base repositories feat: ensure repositories are applied to cluster Oct 13, 2023
@Azhovan Azhovan changed the title feat: ensure repositories are applied to cluster feat: ensure base repositories are applied to cluster Oct 13, 2023
@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2023
@Azhovan Azhovan force-pushed the jabar/fix-base-helmrepositories branch from e7e1bf8 to 8ea16fd Compare October 17, 2023 16:14
@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 17, 2023
@Azhovan Azhovan force-pushed the jabar/fix-base-helmrepositories branch from 8ea16fd to d0b9dba Compare October 17, 2023 18:19
Copy link
Contributor

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the Stale label Nov 17, 2023
@Azhovan Azhovan closed this Nov 27, 2023
@cwyl02 cwyl02 reopened this Mar 27, 2024
@cwyl02 cwyl02 force-pushed the jabar/fix-base-helmrepositories branch from d0b9dba to e6f729a Compare March 27, 2024 14:08
@github-actions github-actions bot removed the Stale label Mar 27, 2024
@cwyl02 cwyl02 merged commit 8182181 into main Mar 27, 2024
9 checks passed
@cwyl02 cwyl02 deleted the jabar/fix-base-helmrepositories branch March 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants