Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: IfNotPresent pull policy for gitea #1678

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Oct 17, 2023

What problem does this PR solve?:

Upstream uses Always https://gitea.com/gitea/helm-chart/src/commit/370775537323ba95fe93fe3d849ad46e860b8575/values.yaml which does not seem efficient and is not consistent with what most other services use so this change overrides it to be more consistent.

More context https://d2iq.slack.com/archives/C01LNF6KML5/p1697577633844619?thread_ts=1697576272.378049&cid=C01LNF6KML5

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/gitea labels Oct 17, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@takirala takirala added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Oct 17, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6552963311

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6508891200: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@takirala takirala self-assigned this Oct 18, 2023
@takirala takirala requested a review from a team October 18, 2023 22:43
@takirala takirala merged commit 8e29621 into main Oct 19, 2023
36 of 37 checks passed
@takirala takirala deleted the tga/gitea-pull-policy branch October 19, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/gitea size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants