Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: verify the health of the kube-prometheus-stack deployment #1693

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

Azhovan
Copy link
Contributor

@Azhovan Azhovan commented Oct 24, 2023

What problem does this PR solve?:
This PR uses the kube-prometheus deployment as a reference point to check the health status of the rollout. The kustomization for kube-prometheus will only be ready when the deployment is healthy

Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-94596

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@Azhovan Azhovan self-assigned this Oct 24, 2023
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. services/kube-prometheus-stack and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Oct 24, 2023

Pull Request Test Coverage Report for Build 6626666786

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6613382370: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

@Azhovan Azhovan added ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review labels Oct 24, 2023
@Azhovan Azhovan force-pushed the jabar/add-healthcheck-kube-prometheus-stack branch from 1464037 to bb06022 Compare October 24, 2023 12:16
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@Azhovan Azhovan force-pushed the jabar/add-healthcheck-kube-prometheus-stack branch from bb06022 to b53fecc Compare October 24, 2023 12:17
@Azhovan Azhovan changed the title feat: add check the deployment of the kube-prometheus-stack feat: verify the health of the kube-prometheus-stack deployment Oct 24, 2023
@Azhovan Azhovan requested review from a team, mhrabovcin, gracedo and jimmidyson October 24, 2023 12:25
@Azhovan Azhovan merged commit aed6a44 into main Oct 25, 2023
19 checks passed
@Azhovan Azhovan deleted the jabar/add-healthcheck-kube-prometheus-stack branch October 25, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review services/kube-prometheus-stack size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants