Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: xxclude ai-nav info agent from the bundle #1735

Merged

Conversation

msdolbey
Copy link
Contributor

@msdolbey msdolbey commented Nov 9, 2023

What problem does this PR solve?:
The ai-navigator-cluster-info-agent would be in the airgapped bundle, and it shouldn't be

Which issue(s) does this PR fix?:
No JIRA - I just thought of it now, but I basically just tried to lift Mikołaj's change here and add the agent to this exclude:
#1655

Special notes for your reviewer:
To be honest - I am mostly just hopeful that this will work the way I want it to.

Does this PR introduce a user-facing change?:
No change, this will just exclude it from the airgapped bundle (new feature, so no change to users)

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Nov 9, 2023

Pull Request Test Coverage Report for Build 6809174681

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 6806135984: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

Copy link
Contributor

@mikolajb mikolajb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤜🏻🤛🏻

Signed-off-by: Mikołaj Baranowski <mikolajb@gmail.com>
@mikolajb mikolajb added the ok-to-test Signals mergebot that CI checks are ready to be kicked off label Nov 9, 2023
@mikolajb mikolajb enabled auto-merge (squash) November 9, 2023 08:24
@mikolajb mikolajb requested a review from a team November 9, 2023 08:24
@mikolajb mikolajb merged commit e85ce47 into main Nov 9, 2023
18 checks passed
@mikolajb mikolajb deleted the QA/excluding-ai-navigator-cluster-info-agent-in-airgapped branch November 9, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Signals mergebot that CI checks are ready to be kicked off size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants