-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: drop ai-navigator images from listing for bundle #1778
Conversation
Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md |
Pull Request Test Coverage Report for Build 7291139716Warning: This coverage report may be inaccurate.We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this change will require us to strip off the images from licenses.d2iq.yaml
file as well. I am not sure about the correctness of this fix.
If this is not acceptable for license scanning and what not (cc @mhrabovcin ), one other option would be move this fix to https://github.com/mesosphere/kommander/blob/main/make/release.mk#L30-L72 as well so that the images are excluded just before building.
looks like need to fix licenses.d2iq.yaml as well |
* build: drop ai-navigator-* images from licenses manifest --------- Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com> (cherry picked from commit 29d9af8)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
* build: drop ai-navigator-* images from licenses manifest --------- Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com> (cherry picked from commit 29d9af8) Co-authored-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
What problem does this PR solve?:
ai-navigator images need not be populated in the airgapped bundle as it does not work (yet) in airgapped environments.
Which issue(s) does this PR fix?:
https://d2iq.atlassian.net/browse/D2IQ-99752
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Checklist