Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop ai-navigator images from listing for bundle #1778

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

takirala
Copy link
Contributor

@takirala takirala commented Dec 19, 2023

What problem does this PR solve?:

ai-navigator images need not be populated in the airgapped bundle as it does not work (yet) in airgapped environments.

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-99752

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 19, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@coveralls
Copy link

coveralls commented Dec 19, 2023

Pull Request Test Coverage Report for Build 7291139716

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.532%

Totals Coverage Status
Change from base Build 7261741271: 0.0%
Covered Lines: 136
Relevant Lines: 171

💛 - Coveralls

Copy link
Contributor Author

@takirala takirala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this change will require us to strip off the images from licenses.d2iq.yaml file as well. I am not sure about the correctness of this fix.

If this is not acceptable for license scanning and what not (cc @mhrabovcin ), one other option would be move this fix to https://github.com/mesosphere/kommander/blob/main/make/release.mk#L30-L72 as well so that the images are excluded just before building.

@cwyl02
Copy link
Contributor

cwyl02 commented Dec 20, 2023

looks like need to fix licenses.d2iq.yaml as well

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@takirala takirala merged commit 29d9af8 into main Jan 2, 2024
9 checks passed
@takirala takirala deleted the tga/remove-ai-images-from-airgapped branch January 2, 2024 17:42
github-actions bot pushed a commit that referenced this pull request Jan 2, 2024
* build: drop ai-navigator-* images from licenses manifest

---------

Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
(cherry picked from commit 29d9af8)
Copy link
Contributor

github-actions bot commented Jan 2, 2024

💚 All backports created successfully

Status Branch Result
release-2.7

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

gracedo pushed a commit that referenced this pull request Jan 2, 2024
* build: drop ai-navigator-* images from licenses manifest

---------

Signed-off-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
(cherry picked from commit 29d9af8)

Co-authored-by: Tarun Gupta Akirala <tarun.akirala@nutanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-to-release-2.7 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants