Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add (re)open events for prs and handle 2+ apps #2279

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

cwyl02
Copy link
Contributor

@cwyl02 cwyl02 commented Jun 3, 2024

for workflow dispatch

What problem does this PR solve?:
right not it doesnt trigger upon new PRs. also it cannot handle more than 1 app

Which issue(s) does this PR fix?:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@cwyl02 cwyl02 requested a review from lukeogg June 3, 2024 16:41
@cwyl02 cwyl02 self-assigned this Jun 3, 2024
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2024
@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 3, 2024
@coveralls
Copy link

coveralls commented Jun 3, 2024

Pull Request Test Coverage Report for Build 9354063287

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.515%

Totals Coverage Status
Change from base Build 9318253798: 0.0%
Covered Lines: 136
Relevant Lines: 264

💛 - Coveralls

@github-actions github-actions bot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2024
@cwyl02 cwyl02 merged commit fc1f475 into main Jun 10, 2024
33 checks passed
@cwyl02 cwyl02 deleted the ychen/app-test-gha-improvements branch June 10, 2024 15:13
SandhyaRavi2403 pushed a commit that referenced this pull request Jul 31, 2024
* ci: add (re)open events for prs and handle 2+ apps

for workflow dispatch

* ci: update var name in test suite job
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
services/reloader size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants