Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump kiwigrid/k8s-sidecar to 1.28.0 #2742

Merged
merged 6 commits into from
Oct 17, 2024

Conversation

Venkat-Bramhasani
Copy link
Contributor

What problem does this PR solve?:

bump kiwigrid/k8s-sidecar to 1.27.6

Which issue(s) does this PR fix?:

https://jira.nutanix.com/browse/NCN-102780

Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@mesosphere-ci mesosphere-ci added ok-to-test Signals mergebot that CI checks are ready to be kicked off do-not-merge/testing Do not merge because there is still on-going testing open-kommander-pr Automatically triggers the creation of a PR in Kommander repo update-licenses signals mergebot to update licenses.d2iq.yaml labels Oct 16, 2024
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/venkat/feat-kiwigrid/k8s-sidecar1.27.6

@coveralls
Copy link

coveralls commented Oct 16, 2024

Pull Request Test Coverage Report for Build 11378045531

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.703%

Totals Coverage Status
Change from base Build 11354739407: 0.0%
Covered Lines: 167
Relevant Lines: 323

💛 - Coveralls

@Venkat-Bramhasani
Copy link
Contributor Author

Hi @mhrabovcin , All checks for this PR have passed, and the CI robot has triggered another PR as part of this process. I reviewed that PR and noticed that all Airgapped checks are failing. Could you please confirm whether those jobs should pass, or if we can ignore them?

licenses.d2iq.yaml Outdated Show resolved Hide resolved
licenses.d2iq.yaml Outdated Show resolved Hide resolved
@mhrabovcin
Copy link
Contributor

@Venkat-Bramhasani I've noticed that there is now new version 1.28.0 available. Lets use that version.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2024
@Venkat-Bramhasani Venkat-Bramhasani force-pushed the venkat/feat-kiwigrid/k8s-sidecar1.27.6 branch from 9ad5337 to 81f2d2f Compare October 17, 2024 04:24
@Venkat-Bramhasani Venkat-Bramhasani force-pushed the venkat/feat-kiwigrid/k8s-sidecar1.27.6 branch from 81f2d2f to f7a969c Compare October 17, 2024 05:29
@Venkat-Bramhasani Venkat-Bramhasani changed the title feat: bump kiwigrid/k8s-sidecar to 1.27.6 feat: bump kiwigrid/k8s-sidecar to 1.28.0 Oct 17, 2024
@Venkat-Bramhasani Venkat-Bramhasani added open-kommander-pr Automatically triggers the creation of a PR in Kommander repo and removed open-kommander-pr Automatically triggers the creation of a PR in Kommander repo labels Oct 17, 2024
Copy link
Contributor

✅ Created Kommander branch to test kommander-applications changes: https://github.com/mesosphere/kommander/tree/kapps/main/venkat/feat-kiwigrid/k8s-sidecar1.27.6

@mhrabovcin mhrabovcin merged commit 1f9f9f1 into main Oct 17, 2024
120 checks passed
@mhrabovcin mhrabovcin deleted the venkat/feat-kiwigrid/k8s-sidecar1.27.6 branch October 17, 2024 14:52
ArvinderPal09 pushed a commit that referenced this pull request Oct 21, 2024
* feat: bump kiwigrid/k8s-sidecar to 1.27.6

* Update licenses.d2iq.yaml

Co-authored-by: Martin Hrabovcin <martin.hrabovcin@nutanix.com>

* feat: bump kiwigrid/k8s-sidecar to 1.27.6

* feat: bump kiwigrid/k8s-sidecar to 1.27.6

* feat: bump kiwigrid/k8s-sidecar to 1.27.6

* feat: bump kiwigrid/k8s-sidecar to 1.28.0

---------

Co-authored-by: Martin Hrabovcin <martin.hrabovcin@nutanix.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/testing Do not merge because there is still on-going testing ok-to-test Signals mergebot that CI checks are ready to be kicked off open-kommander-pr Automatically triggers the creation of a PR in Kommander repo services/centralized-grafana services/centralized-kubecost services/grafana-logging services/kube-prometheus-stack services/kubecost services/project-grafana-logging size/M Denotes a PR that changes 30-99 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants