Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user-custom VS Code settings #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jcbhmr
Copy link
Collaborator

@jcbhmr jcbhmr commented Jun 3, 2023

This PR would...

  • Remove the .vscode/settings.json

It's generally recommended that formatting stuff like formatOnSave and other such rules go in your own custom user-specific VS Code settings. In general, I think that .vscode/settings.json is more for project-specific patches on things like file extension association, extension customization (like enabling "Deno mode" for tsc checking) or other workspace-specific things.

This also helps encourage better formatting scripts like running prettier -w . or similar to actually enforce these settings for all users even those using Neovim or JetBrains or whatever.

Also on a popularity note, .vscode/settings.json files are relatively rare, especially in comparison to prettierrc files! 37k vs 101k and that's just the js prettier ecosystem! 😱

If there's a genuine workflow improvement or reason for this file to be here, then I'd love to hear it and add that explanation to the readme! ❤️ Documentation about code workflow stuff is a good thing 👍

@jcbhmr jcbhmr requested a review from mesqueeb June 3, 2023 19:16
@jcbhmr jcbhmr self-assigned this Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant