Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #115

Merged
merged 31 commits into from
Jun 1, 2018
Merged

Dev #115

merged 31 commits into from
Jun 1, 2018

Conversation

SilasK
Copy link
Member

@SilasK SilasK commented Jun 1, 2018

contains all changes for now found in #114 #102 #111

I'm testing this branch

SilasK and others added 30 commits March 19, 2018 12:03
The keyword `physcov`in pileup counts the bases between correctly mapped, not overlapping paired-end reads as covered. 
I think this is a great feature but it is incopatibl with asking bbmap to map to all ambigous sites `ambigous=all`
Contigs should be filtered based on all possible mappings. 
As we have the option in the `align_reads_to_final_contigs` we should filter contigs based on all ambigous mapping results and not only on the best (default).
merged reads are used sperately by spades.
added possibility to drop normalization
made filtering optional
not tested
@brwnj brwnj merged commit 4a1b03b into master Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants