Skip to content

Commit

Permalink
Use unix sockets by default for reverse proxy communication
Browse files Browse the repository at this point in the history
Using additional ports increase the chance of conflicting with something
else on the node and is also potentially less efficient. We have used
Unix sockets via a shared directory in OpenShift for a while without any
complaints. I think upstream should do the same.

Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
  • Loading branch information
dtantsur committed Apr 9, 2024
1 parent e5e5093 commit dd107a8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions scripts/ironic-common.sh
Original file line number Diff line number Diff line change
Expand Up @@ -93,8 +93,8 @@ run_ironic_dbsync()
}

# Use the special value "unix" for unix sockets
export IRONIC_PRIVATE_PORT=${IRONIC_PRIVATE_PORT:-6388}
export IRONIC_INSPECTOR_PRIVATE_PORT=${IRONIC_INSPECTOR_PRIVATE_PORT:-5049}
export IRONIC_PRIVATE_PORT=${IRONIC_PRIVATE_PORT:-unix}
export IRONIC_INSPECTOR_PRIVATE_PORT=${IRONIC_INSPECTOR_PRIVATE_PORT:-unix}

export IRONIC_ACCESS_PORT=${IRONIC_ACCESS_PORT:-6385}
export IRONIC_LISTEN_PORT=${IRONIC_LISTEN_PORT:-$IRONIC_ACCESS_PORT}
Expand Down

0 comments on commit dd107a8

Please sign in to comment.