[WIP] 🌱 Backward compable callback endpoint when Inspector is off #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
dtantsur
changed the title
metal3-io-bot
added
size/M
|
/test-centos-integration-main |
dtantsur
force-pushed
the
inspector-compat
branch
from
3282ee4
to
4b933a5
Compare
|
/test-centos-integration-main |
Some PreprovisioningImage controller, like the one we have downstream,
hardcode {IP}:5050/v1/continue in their IPA configuration. To avoid
updating them in a lockstep with disabling Inspector, provide a small
virtual host that proxies :5050/v1/continue to :6385/v1/continue_inspection.
Signed-off-by: Dmitry Tantsur <dtantsur@protonmail.com>
dtantsur
force-pushed
the
inspector-compat
branch
from
4b933a5
to
16fca9b
Compare
|
/test-centos-integration-main |
1 similar comment
|
/test-centos-integration-main |
|
I have alternative ideas and probably won't pursue this path. |
elfosardo
pushed a commit
to elfosardo/ironic-image
that referenced
this pull request
Apr 19, 2024
OCPBUGS-31830,OCPBUGS-31686,OCPBUGS-31802: [4.15] install ironic projects from source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some PreprovisioningImage controller, like the one we have downstream,
hardcode {IP}:5050/v1/continue in their IPA configuration. To avoid
updating them in a lockstep with disabling Inspector, provide a small
virtual host that proxies :5050/v1/continue to :6385/v1/continue_inspection.
Signed-off-by: Dmitry Tantsur dtantsur@protonmail.com