Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] test ci #475

Closed
wants to merge 1 commit into from
Closed

Conversation

elfosardo
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from elfosardo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 6, 2024
@elfosardo
Copy link
Member Author

/test-ubuntu-integration-main

@elfosardo
Copy link
Member Author

/markdownlint

@elfosardo
Copy link
Member Author

/test-ubuntu-integration-main

Signed-off-by: Riccardo Pittau <elfosardo@gmail.com>
@elfosardo
Copy link
Member Author

/test-ubuntu-integration-main

@tuminoid
Copy link
Member

tuminoid commented Feb 7, 2024

/test-ubuntu-integration-main
//test-centos-integration-main

@tuminoid
Copy link
Member

tuminoid commented Feb 7, 2024

/test-centos-integration-main

@tuminoid
Copy link
Member

tuminoid commented Feb 7, 2024

/test-ubuntu-integration-main
/test-centos-integration-main

3 similar comments
@tuminoid
Copy link
Member

tuminoid commented Feb 7, 2024

/test-ubuntu-integration-main
/test-centos-integration-main

@tuminoid
Copy link
Member

tuminoid commented Feb 7, 2024

/test-ubuntu-integration-main
/test-centos-integration-main

@tuminoid
Copy link
Member

tuminoid commented Feb 7, 2024

/test-ubuntu-integration-main
/test-centos-integration-main

@kashifest
Copy link
Member

the triggers doesnt look correct, we using main branch test trigger here, perhaps we should use the correct branch name. Let me check if everything is up to date in gerrit repo

@kashifest
Copy link
Member

/test-ironic-image-build

@kashifest
Copy link
Member

ok it seems like we do not have the logic to test the release branches yet , cause for that we have to decide which branch of BMO we should test for a given ironic release branch, currently we run these integration tests based on CAPM3 branches and CAPM3 and BMO branches are coupled together for the integration tests (we should change this), we can also use BMO e2e tests here but then again we need to know for which branch of BMO we should test which branch of ironic!!! the
ironic-image-build pipeline is another thing that we can leverage, currently its only building ironic image and that also from rpm for some legacy reason, we can perhaps improve this and add options to test integration of different ironic image branches with BMO/CAPM3.

@elfosardo elfosardo closed this Mar 12, 2024
elfosardo pushed a commit to elfosardo/ironic-image that referenced this pull request Apr 25, 2024
OCPBUGS-32388: Use unix sockets by default for reverse proxy communication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants