Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛SQLite: fix Ironic container restarting issue #566

Conversation

metal3-io-bot
Copy link
Contributor

This is an automated cherry-pick of #563

/assign tuminoid

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1-7

@tuminoid
Copy link
Member

/retitle 🐛SQLite: fix Ironic container restarting issue

@metal3-io-bot metal3-io-bot changed the title [release-24.1] 🐛SQLite: fix Ironic container restarting issue 🐛SQLite: fix Ironic container restarting issue Sep 20, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/cc @elfosardo

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
@elfosardo
Copy link
Member

/retest

1 similar comment
@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

Are we having some Python or baseimage issues?

[2024-09-23T16:25:16.133Z]     ERROR: Command errored out with exit status 1:
[2024-09-23T16:25:16.133Z]      command: /usr/bin/python3 -u -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-nz17nwvr/jsonpath-rw_2f5f16245ab54bd99221743caaa430f5/setup.py'"'"'; __file__='"'"'/tmp/pip-install-nz17nwvr/jsonpath-rw_2f5f16245ab54bd99221743caaa430f5/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /tmp/pip-record-ux3_xuwh/install-record.txt --single-version-externally-managed --prefix /usr --compile --install-headers /usr/include/python3.9/jsonpath-rw
[2024-09-23T16:25:16.133Z]          cwd: /tmp/pip-install-nz17nwvr/jsonpath-rw_2f5f16245ab54bd99221743caaa430f5/
[2024-09-23T16:25:16.133Z]     Complete output (19 lines):
[2024-09-23T16:25:16.133Z]     Traceback (most recent call last):
[2024-09-23T16:25:16.133Z]       File "<string>", line 1, in <module>
[2024-09-23T16:25:16.133Z]       File "/tmp/pip-install-nz17nwvr/jsonpath-rw_2f5f16245ab54bd99221743caaa430f5/setup.py", line 7, in <module>
[2024-09-23T16:25:16.133Z]         setuptools.setup(
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/setuptools/__init__.py", line 117, in setup
[2024-09-23T16:25:16.133Z]         return distutils.core.setup(**attrs)
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/setuptools/_distutils/core.py", line 145, in setup
[2024-09-23T16:25:16.133Z]         _setup_distribution = dist = klass(attrs)
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 283, in __init__
[2024-09-23T16:25:16.133Z]         _Distribution.__init__(self, dist_attrs)
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/setuptools/_distutils/dist.py", line 279, in __init__
[2024-09-23T16:25:16.133Z]         self.finalize_options()
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 635, in finalize_options
[2024-09-23T16:25:16.133Z]         ep(self)
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/setuptools/dist.py", line 655, in _finalize_setup_keywords
[2024-09-23T16:25:16.133Z]         ep.load()(self, ep.name, value)
[2024-09-23T16:25:16.133Z]       File "/usr/lib/python3.9/site-packages/importlib_metadata/__init__.py", line 211, in load
[2024-09-23T16:25:16.133Z]         return functools.reduce(getattr, attrs, module)
[2024-09-23T16:25:16.134Z]     AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'

@tuminoid
Copy link
Member

/retest

@tuminoid
Copy link
Member

/retest

Maybe needs rebase?

@tuminoid
Copy link
Member

Ah even the fix is still pending merging. Maybe next week then.

In case of SQLite implementation Ironic container fails to restart.
create_schema will be called only when required.

fix metal3-io#562

Signed-off-by: LALLAU Bertrand <blallau@github.com>
@tuminoid tuminoid force-pushed the cherry-pick-563-to-release-24.1 branch from 03c7b57 to e10acd6 Compare September 27, 2024 13:27
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@tuminoid
Copy link
Member

/test metal3-centos-e2e-integration-test-release-1-7 metal3-ubuntu-e2e-integration-test-release-1-7

@tuminoid
Copy link
Member

/retest

Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 27, 2024
@elfosardo
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024
@metal3-io-bot metal3-io-bot merged commit 760254f into metal3-io:release-24.1 Sep 30, 2024
8 checks passed
iurygregory pushed a commit to iurygregory/ironic-image that referenced this pull request Oct 2, 2024
NO-ISSUE: fix scos and fcos dockerfiles to remove ironic-inspector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants