Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec breaking on invalid uris #119

Merged
merged 8 commits into from
Aug 2, 2024
Merged

Spec breaking on invalid uris #119

merged 8 commits into from
Aug 2, 2024

Conversation

kwkwan
Copy link
Contributor

@kwkwan kwkwan commented Jul 10, 2024

Metanorma PR checklist

@kwkwan kwkwan linked an issue Jul 10, 2024 that may be closed by this pull request
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we not change the XMI file?Because that is what the user exports directly, we can't ask them to change those namespaces to match.

@kwkwan
Copy link
Contributor Author

kwkwan commented Jul 11, 2024

Yes, but we need to create xmi models with namespace XML 20110701 and UML 20110701. Since Shale models will verify the url of the namespaces.

@ronaldtse
Copy link
Contributor

That means we should support the older export formats? If we don't support the older formats, we need to state which formats are supported, and we should also re-export this XMI file using a newer version instead of manually changing the XML.

@opoudjis
Copy link
Contributor

I don't have an opinion here, but these solutions in general do need to err on the side of tolerance of data...

@ronaldtse
Copy link
Contributor

@kwkwan is this to be merged? If so please merge it, thanks.

@kwkwan
Copy link
Contributor Author

kwkwan commented Aug 2, 2024

@kwkwan is this to be merged? If so please merge it, thanks.

Ok. Got it.

@kwkwan kwkwan merged commit 33d93ae into main Aug 2, 2024
16 of 17 checks passed
@kwkwan kwkwan deleted the spec-breaking-on-invalid-uris branch August 2, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec breaking on invalid URIs
3 participants