Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: logic for archiving dataroom #1051

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Khaan25
Copy link

@Khaan25 Khaan25 commented Oct 16, 2024

This PR fixes: #785

I've included a boolean in the function to archive a dataroom.

Will discuss some key points with @mfts and finish this feature.

@Khaan25 Khaan25 requested a review from mfts as a code owner October 16, 2024 06:27
Copy link

vercel bot commented Oct 16, 2024

@Khaan25 is attempting to deploy a commit to the mftsio Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Oct 16, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@mfts
Copy link
Owner

mfts commented Oct 16, 2024

@Khaan25 looks good so far

  • missing a field on Dataroom table for isArchived
  • also missing the tab for the archived datarooms

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

Yes, I'm gonna work on it

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

Hey, In the Link table, we've isArchived field, is that for any other usecase?

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

image

Here's a video: https://streamable.com/0yl2ym

Could not upload more than 10 MBs of video on GitHub :)
FYI, Video link expires after 2 days :)

@Khaan25
Copy link
Author

Khaan25 commented Oct 17, 2024

Just a quick question,
image

You can see the image above, if we're on trial and we create dataroom then the trial-banner day isn't showing because it's fetching from the first data-room tab in the image, how about we proceed?

My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"

What do you say?

@mfts
Copy link
Owner

mfts commented Oct 20, 2024

@Khaan25

My initial thoughts are, query for first tab, if null then query for second tab, that way we won't have "days left" but "X days left"

Don't worry about that trial banner. it's a minor thing

@Khaan25
Copy link
Author

Khaan25 commented Oct 20, 2024

Alright. So we should mark this issue as complete?

@mfts
Copy link
Owner

mfts commented Oct 21, 2024

@Khaan25 please sign the CLA as indicated above

@Khaan25
Copy link
Author

Khaan25 commented Oct 21, 2024

/recheck

@Khaan25
Copy link
Author

Khaan25 commented Oct 21, 2024

recheck

@Khaan25
Copy link
Author

Khaan25 commented Oct 21, 2024

I have read the CLA Document and I hereby sign the CLA

@Khaan25
Copy link
Author

Khaan25 commented Oct 21, 2024

@mfts I've signed it

Copy link
Owner

@mfts mfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes, see inline comments.

Ideally we want to reduce code duplication

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a redundant endpoint.

Better to add a "archived" query to GET /datarooms endpoint and then based on that return either all archived or non-archived documents.

Especially since this endpoint is not returning any more information than the index.ts

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be replicated on /view/domains/[domain]/[slug]/index.ts

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the URL or a button to view view/domains/[domain]/[slug] route?

@mfts mfts added revisit Currently not required but important in the future 🕹️ oss.gg 🕹️ 300 points iteration-1 labels Oct 22, 2024
@Khaan25
Copy link
Author

Khaan25 commented Oct 22, 2024

Sure, I'll do it and let you know

yarn.lock Outdated Show resolved Hide resolved
@Khaan25
Copy link
Author

Khaan25 commented Oct 22, 2024

@mfts I've pushed the changes, can you please review?

@mfts
Copy link
Owner

mfts commented Oct 22, 2024

@Khaan25 looks good. I will make some small changes today and then push it

@Khaan25
Copy link
Author

Khaan25 commented Oct 22, 2024

Cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🕹️] Add the ability to archive a dataroom
2 participants