-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pass theme option as url params #1097
base: main
Are you sure you want to change the base?
fix: pass theme option as url params #1097
Conversation
@DeepaPrasanna is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
/assign |
The /assign command can only be used on issues, not on pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DeepaPrasanna I think we have a misunderstanding.
The sender should add the ?theme=dark|light
to the Notion URL when they are uploading it to Papermark.
From there we are extracting it and passing it into the NotionPage
component.
The actual Papermark link does not change
@DeepaPrasanna please have a look at my last comment |
I am really sorry for the delay. I will update within few hours. |
No rush. I know you are also busy with other things. But great to keep this PR moving along. |
@mfts Thank you for your patience :) I have taken into account your reviews and updated the code. Pls also refer to the screen recording showing the changes. Also, I think this may require updating docs so that users may know to send the query params for dark mode while uploading. |
fixes #791
Summary of changes: passed mode as the url param in the notion link and update the darkMode value in Notion doc