-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: og image (dynamic route) #778
base: main
Are you sure you want to change the base?
Conversation
@zaCKoZAck0 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
@zaCKoZAck0 looks good for now. Let me know if you have any questions |
I have read the CLA Document and I hereby sign the CLA |
@zaCKoZAck0 are you still working on this issue? |
Hi @mfts ,
Few workarounds:
What path should I take next?, I've updated the current state of OG preview in the PR description. |
@zaCKoZAck0 thanks for the transparency. Perhaps you can then design a OG image that takes the name of the document, Papermark and then a standard papermark image. Something that we could swap out in the future as a standard image. |
@zaCKoZAck0 let me know if you'd like to proceed with this PR? |
Hi @mfts , Here's from another office suite. We can replace the grey area of the og image with a placeholder illustration image like this. That will let the user know what type of document it is. |
For Sheet, Image, Slides, Dataroom and other files @mfts please review the above placeholder images. |
Related to #629
[WIP]: add og images for file sharing url.
Draft:
Currently og image looks something like this:
Last updated 12-10-24