-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
last used indicator on login page fixed #850
base: main
Are you sure you want to change the base?
Conversation
@sahiladit is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
@sahiladit could you please share a video what you mean? if the user hasn't logged in ever then of course there's no "last used". |
It fixes #841 |
ok sounds good. please sign the CLA |
Can you give me the steps to sign it? It's my first time contributing to an org.. |
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
recheck |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Hi @sahiladit, It's great to hear on your first contribution, many more to go! One small thing...I tried with incorporating your changes but I seems like the similar behavior still on. The expected behaviour is until it get's navigated to the next screen / till successful login the indicator shouldn't show. And say lastlogin is indicating on 13.10.2024_12.02.42_REC.mp4https://lex.page/auth And a sample implementations can be find here |
I think i have resolved this ,try to run my code ,it's not merged yet,and if you still find it let me know. |
Hi @sahiladit, I’m aware the code hasn’t been merged yet. Before posting my previous comment, I incorporated your changes into the code (tried with your code), but the issue still remains. Would you mind checking it :-) |
Okay,thanks for the check, i'll try to resolve it. |
@sahiladit any update on the last changes? |
Making some changes, will open a pr today. |
@sahiladit just add to this PR :) |
how can i change the code in existing pr? |
You can make changes in the same branch in your code(sahiladit:fix/last-used-indicator) and push it. |
i have made the changes,should i recheck it here? |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sahiladit there's a build error.
TypeError: Cannot destructure property 'data' of '(0 , N.useSession)(...)' as it is undefined.
at Z (/vercel/path0/.next/server/app/(auth)/login/page.js:1:9627)
at nj (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:46251)
at nM (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:47571)
at nN (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:64546)
at nI (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:47010)
at nM (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:47717)
at nM (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:61546)
at nN (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:64546)
at nB (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:67538)
at nD (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:66680) {
digest: '600978353'
}
Error occurred prerendering page "/login". Read more: https://nextjs.org/docs/messages/prerender-error
TypeError: Cannot destructure property 'data' of '(0 , N.useSession)(...)' as it is undefined.
at Z (/vercel/path0/.next/server/app/(auth)/login/page.js:1:9627)
at nj (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:46251)
at nM (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:47571)
at nN (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:64546)
at nI (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:47010)
at nM (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:47717)
at nM (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:61546)
at nN (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:64546)
at nB (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:67538)
at nD (/vercel/path0/node_modules/next/dist/compiled/next-server/app-page.runtime.prod.js:12:66680)
Generating static pages (8/35)
Generating static pages (17/35)
Generating static pages (26/35)
please resolvre that and try to npm run build
it yourself locally first
@sahiladit please have a look at the last build error. |
Fixes:#841
#what does this pr do:
Now the indicator now only pops up when user click on any of the login mode and not when the user enters for the first time.