-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
archive functionality added in document section #946
base: main
Are you sure you want to change the base?
Conversation
…in dropdown menu of document-card
@Anky9972 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
All contributors have signed the CLA ✍️ ✅ |
recheck |
I have read the CLA Document and I hereby sign the CLA |
@Anky9972 can you make the I'm thinking about a tab that leads to |
Ok, I will do it as soon as possible. |
@mfts check it Screencast.from.2024-10-16.16-46-11.mp4 |
@mfts Did you review the changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good progress. Some minor changes that will make maintaining it easier in the long run.
Focus on reusability. For example the documents-list can also serve for archived documents. Don't need to duplicate the same code.
import { ArchivedDocumentsList } from "@/components/documents/archived-document-list"; | ||
|
||
export default function Documents() { | ||
const { documents,error } = useDocuments(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would expect to only fetch archived documents here, not all documents. so you could add a variable to the useDocuments
swr hook and then only fetch the archived documents.
|
||
export default function Documents() { | ||
const { documents,error } = useDocuments(); | ||
const { folders } = useRootFolders(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this you probably don't need in the archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
formatting is a bit off. why are there so many changes to parts of the file that have nothing to do with your implementation?
@Anky9972 please have a look at the latest change requests |
@mfts Sure working on them let you know in 2 or 3 days. |
#788
We added the archive document functionality in document section in which user can archive and retrieve the document and delete the document from archive section as required.
Screencast.from.2024-10-14.15-45-07.mp4