-
Notifications
You must be signed in to change notification settings - Fork 723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opt-in-to-group-permission #947
opt-in-to-group-permission #947
Conversation
@AshishViradiya153 is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
PR Summary
|
@mfts One more thing, I can only see the folder tree on the home not documents. Should I create an issue for that? https://github.com/user-attachments/assets/2d223ba2-205f-4c35-8e28-d6c9f20eca52) |
Good catch! That's something we haven't quite solved yet. Generally, in the dataroom view tree there is no "home" folder. However that would make sense to add as a "fictional" parent folder. Would be awesome to add that in a separate PR perhaps |
THANKS @mfts. |
@AshishViradiya153 while this is a good idea. I think in the current form it's not really useful. What would be useful, is to set the permission for the folder/document for a certain group from that dialog popup. What do you think? |
@mfts I got it, you're right! and also makes sense! |
@AshishViradiya153 do you want to continue working on this group permissions pop-up or rather open a new PR? |
@mfts I will open a new PR for that and a new issue as well. I think it will be a big PR. I have already started and finished 40% of the work, but it will take more time than I initially thought, Sorry. |
@AshishViradiya153 no problem. Open the PR before Oct 31 so i can still reward you even if it takes longer to merge |
fixes #697
It will redirect to group permission page