Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix 1.5 #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

geofflane
Copy link

To use with the latest Phoenix, needed to update the dependencies.
use Phoenix.ConnTest is deprecated.
The HTML "AST" generated by the latest Phoenix HTML is different than previous, so had to change the tests, but confirm it worked. Not sure how you'd support multiple versions with these changes?

@dbii
Copy link

dbii commented Jul 28, 2020

I think this should be have CI ran again, since it failed with a weird error on telemetry. I branched and did almost the same changes as this and my local tests pass (some mix packages may be a little more current in my fork).

@thbar
Copy link

thbar commented Jan 11, 2021

This looks like a good candidate to fix #97. Any chance to get this merged? A lot of people have moved to Phoenix 1.5, so it would be greatly beneficial.

Any way we can help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants