Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adodbapi: Remove redundant object subclassing #2086

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

Avasam
Copy link
Collaborator

@Avasam Avasam commented Jul 23, 2023

Extracted from #2094 for easier review. This contains no functional changes for Python 3.

@mhammond
Copy link
Owner

LGTM, ok with you @vernondcole?

@Avasam Avasam changed the title Remove redundant object subclassing Remove redundant object subclassing in adodbapi Aug 10, 2023
@Avasam Avasam changed the title Remove redundant object subclassing in adodbapi adodbapi: Remove redundant object subclassing Aug 12, 2023
@Avasam
Copy link
Collaborator Author

Avasam commented Mar 25, 2024

@vernondcole This should be a very safe and easy change

@Avasam Avasam requested a review from vernondcole March 25, 2024 17:43
Copy link
Collaborator

@vernondcole vernondcole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@Avasam Avasam merged commit 50436c4 into mhammond:main Apr 9, 2024
27 checks passed
@Avasam Avasam deleted the remove-redundant-object-subclassing branch April 9, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants