Completely type win32timezone
#2334
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Jul 27, 2024
Avasam
commented
Jul 27, 2024
jaraco
approved these changes
Jul 27, 2024
Avasam
commented
Jul 27, 2024
Comment on lines
-684
to
-747
| def __le__(self, other): | ||
| return self.__dict__ < other.__dict__ |
There was a problem hiding this comment.
In #1990 I updated __cmp__ for __le__, but that doesn't make sense for dicts. Comparisons of TimeZoneInfo has been broken since Python 3 anyway so removing this doesn't remove any functionality.
Avasam
commented
Jul 27, 2024
Comment on lines
936
to
+945
| """Resolve a multilingual user interface resource for the time zone name | ||
|
|
||
| spec should be of the format @path,-stringID[;comment] | ||
| see http://msdn2.microsoft.com/en-us/library/ms725481.aspx for details | ||
|
|
||
| >>> import sys | ||
| >>> result = resolveMUITimeZone('@tzres.dll,-110') | ||
| >>> expectedResultType = [type(None),str][sys.getwindowsversion() >= (6,)] | ||
| >>> type(result) is expectedResultType | ||
| True |
There was a problem hiding this comment.
I had accidentally removed a bit too much in https://github.com/mhammond/pywin32/pull/2085/files#diff-e5d2b4683af028d6a25d25c862c248214190080072e6f07171106c56dd7812dc
…into type-win32timezone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*args/*kwargsparams)TimeZoneInfo.tzname(see Fix bugs in TimeZoneInfo.tzname #2337).RangeMapfromjaraco.collections& MadeRangeMapgenerictznamehandlesNoneparam as per the official docFixedFixTimeZoneDefinitioncreation from aTIME_ZONE_INFORMATIONorDYNAMIC_TIME_ZONE_INFORMATION(used to crash):win32timezone.TimeZoneInfo.__init_from_otherand added tests #2339I plan on bringing
RangeMapimprovements over tojaraco.collections. Edit: jaraco/jaraco.collections#16CC @jaraco