-
Notifications
You must be signed in to change notification settings - Fork 798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent usage of end-of-statement marker with macros (better clang-format out of the box) & Make the CI step actually fail on failure #2405
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@mhammond Just to confirm before I add to the .git-blame-ignore: you prefer this config change over removing |
I don't have a strong opinion here, but I think it kinda seems more natural for people to not use a trailing WDYT? |
My gut feeling is that it would be nice not special case certain methods in configuration. It would also make usage more consistent (for example |
Closes #1412
Found with the regex
#define .+?;
(it may not find everything, but found a few)Alternatively, the
;
can be removed from the macros themselves to force adding it in-code, not having to add any configuration (my instinct is to say that might be clearer for devs anyway, and removes specialized configuration, but up to you)(I'll add an entry to the
.git-blame-ignore-revs
after its decided which solution you prefer)