Remove __file__ try-catch hack + Comment about __file__ always being absolute in 3.9
#2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
Remove-__file__-try-catch-hack
branch
from
8132c04
to
605ee2d
Compare
Avasam
commented
Oct 16, 2024
| import win32com | ||
|
|
||
| # We'd prefer the win32com namespace to be the parent of __file__ - ie, our source-tree, | ||
| # rather than the version installed - otherwise every .py change needs a full install to | ||
| # test! | ||
| # TODO: That sounds like a use-case for editable installs ! |
|
Hmm. That 3.9 comment may not be entirely correct. Apparently it's only for the main module. I'll revise this PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I expect the same comment should apply to
win32api.GetFullPathName(__file__)but I wasn't completely sure ? (just in caseGetFullPathNamedoes something special that might still be worth calling on an absolute path).Python 3.8 goes EOL at the end of this month. These
os.path.abspathcan go away then.