Resolves error #150 #158
Open
Resolves error #150 #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -264,11 +263,6 @@ class HitBtcMarketDataGateway implements Interfaces.IMarketDataGateway { | |||
| this.onConnectionStatusChange); | |||
| this._marketDataWs.connect(); | |||
|
|
|||
| this._tradesClient = io.connect(config.GetString("HitBtcSocketIoUrl") + "/trades/" + this._symbolProvider.symbol); | |||
| this._tradesClient.on("connect", this.onConnectionStatusChange); | |||
| this._tradesClient.on("trade", this.onTrade); | |||
There was a problem hiding this comment.
We can't take out the _tradesClient, there needs to be a way to get prints.
ctubio
added a commit
to ctubio/tribeca
that referenced
this pull request
Aug 22, 2017
Free Software Free Society To support commits by ctubio, you can buy-me-a-drink with a small git tip at: 1GitTipgxvKB3zjCLXRcSgDhC9pivkpc7u I promise to drink chocolate milk in the development of the next commit. To request new features or in case this commit breaks something for you, please create a new github issue with all possible details, but never share your API Keys! Signed-off-by: Carles Tubio <ctubio@users.noreply.github.com>
ctubio
added a commit
to ctubio/tribeca
that referenced
this pull request
Aug 23, 2017
Free Software Free Society To support commits by ctubio, you can buy-me-a-drink with a small git tip at: 1GitTipgxvKB3zjCLXRcSgDhC9pivkpc7u I promise to drink chocolate milk in the development of the next commit. To request new features or in case this commit breaks something for you, please create a new github issue with all possible details, but never share your API Keys! Signed-off-by: Carles Tubio <ctubio@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves authentication issue with HitBTC. Used solution from ctubio/Krypto-trading-bot@1a28b5b.