-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor of PACVr.complete
; decoding IRCheck
as a single variable; handle use of note
qualifier for IR name
#27
Refactor of PACVr.complete
; decoding IRCheck
as a single variable; handle use of note
qualifier for IR name
#27
Conversation
This reverts commit bdedd2a.
PACVr.complete
& decoding IRCheck
as a single variablePACVr.complete
, decoding IRCheck
as a single variable,
PACVr.complete
, decoding IRCheck
as a single variable, PACVr.complete
; decoding IRCheck
as a single variable; handle use of note
qualifier for IR name
6efad5c
into
michaelgruenstaeudl:master
Hi Greg, Continuing this goal of providing clarification, can you please rename any variable and function called "verbose" or "verboseInformation()" with "printCovStats()" (or words to that effect), which is what it actually does. Similarly, "writeTables()" should be renamed to "printCovValsAsTable()" (or words to that effect). Also, it would be fantastic if these coverageStats could be calculated irrespective of Thank you and best, Michael |
In an attempt to reduce the complexity present in
PACVr.complete
, code responsible for producing an individual variable is present as its own function withinPACVr.R
. For similar reasons, the bulk of the code forPACVr.verboseInformation
has been moved tohelpers.R
. Related to this goal of better clarity, the parameter ofPACVR.complete
IRCheck
is decoded into a single variable, which can then be passed accordingly and have its elements be accessed as needed.To address variances in GenBank data, specifically regarding which qualifier is used to detail inverted repeat names, additional checks within
checkFeatureQualifiers
are performed.