append to subscribers (#2640) #135
jochumdevAnnotations
12 errors and 10 warnings
|
Lint:
api/api.go#L20
interface method Init must have all named params (inamedparam)
|
|
Lint:
api/api.go#L24
interface method Register must have all named params (inamedparam)
|
|
Lint:
api/api.go#L26
interface method Deregister must have all named params (inamedparam)
|
|
Lint:
api/api.go#L28
interface method Run must have named param for type context.Context (inamedparam)
|
|
Lint:
api/api.go#L148
ifElseChain: rewrite if-else to switch statement (gocritic)
|
|
Lint:
api/api_test.go#L8
cognitive complexity 51 of func `TestEncoding` is high (> 30) (gocognit)
|
|
Lint:
api/client/client.go#L14
import 'github.com/gorilla/websocket' is not allowed from list 'Main' (depguard)
|
|
Lint:
api/client/client.go#L125
should rewrite http.NewRequestWithContext or add (*Request).WithContext (noctx)
|
|
Lint:
api/client/client.go#L193
response body must be closed (bodyclose)
|
|
Lint:
api/default.go#L50
Error return value is not checked (errcheck)
|
|
Unit Tests
Process completed with exit code 1.
|
|
Summary Report
Process completed with exit code 1.
|
|
Lint:
api/api.go#L16
exported: comment on exported type Api should be of the form "Api ..." (with optional leading article) (revive)
|
|
Lint:
api/api.go#L18
var-naming: type Api should be API (revive)
|
|
Lint:
api/api.go#L182
var-naming: func NewApi should be NewAPI (revive)
|
|
Lint:
api/default.go#L19
var-naming: func newApi should be newAPI (revive)
|
|
Lint:
api/options.go#L10
exported: exported function NewOptions should have comment or be unexported (revive)
|
|
Lint:
config/source/cli/cli.go#L1
package-comments: should have a package comment (revive)
|
|
Lint:
config/source/cli/cli.go#L81
unused-parameter: parameter 'cs' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
debug/handler/debug.go#L18
unused-parameter: parameter 'c' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Lint:
debug/handler/debug.go#L28
exported: exported type Debug should have comment or be unexported (revive)
|
|
Lint:
debug/handler/debug.go#L39
exported: exported method Debug.Health should have comment or be unexported (revive)
|