Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Class:OmicsProcessing to Class:DataGeneration #2

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Change Class:OmicsProcessing to Class:DataGeneration #2

merged 3 commits into from
Dec 12, 2023

Conversation

turbomam
Copy link
Member

@turbomam turbomam commented Dec 12, 2023 •
edited by mslarae13
Loading

Collections requiring migration:

  • omics_ocessing_set

Workflows requiring migration:

  • All workflow classes will need to refer to the new class

@turbomam turbomam linked an issue Dec 12, 2023 that may be closed by this pull request
global replace OmicsProcessing with DataGeneration microbiomedata/nmdc-schema#1515
Closed
@aclum aclum requested a review from brynnz22 December 12, 2023 20:00
@aclum aclum marked this pull request as draft December 12, 2023 20:01
@turbomam turbomam marked this pull request as ready for review December 12, 2023 22:06
brynnz22
brynnz22 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@brynnz22 brynnz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@brynnz22 brynnz22 merged commit 7d5036f into main Dec 12, 2023
2 checks passed
@mslarae13 mslarae13 changed the title #1515 omicsproc -> datagen #1515 Change Class:OmicsProcessing to Class:DataGeneration Dec 18, 2023
@mslarae13 mslarae13 added the migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. label Dec 18, 2023
@brynnz22 brynnz22 mentioned this pull request Dec 28, 2023
Closed
@brynnz22 brynnz22 added the migrator-overhaul-needed The current migrator design is not sufficient to tackle the migration label Jan 6, 2024
This was referenced Feb 16, 2024
Closed
Merged
@brynnz22 brynnz22 added the migrator-written a migrator script has been written addressing the PR/schema change label Feb 16, 2024
@turbomam turbomam deleted the 1515-global-replace-omicsprocessing-with-datageneration branch March 29, 2024 13:57
@brynnz22 brynnz22 changed the title #1515 Change Class:OmicsProcessing to Class:DataGeneration Change Class:OmicsProcessing to Class:DataGeneration Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brynnz22 brynnz22 brynnz22 approved these changes

Assignees
No one assigned
Labels
migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. migrator-overhaul-needed The current migrator design is not sufficient to tackle the migration migrator-written a migrator script has been written addressing the PR/schema change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

global replace OmicsProcessing with DataGeneration
3 participants
@turbomam @brynnz22 @mslarae13