Pre vs berkeley DO NOT MERGE HERE #275
Conversation
|
|
@turbomam - thanks a bunch! - this is terrific.
|
There was a problem hiding this comment.
- add single markdown file link to left hand nav bar on main NMDC index doc page as "NMDC Schema Migration Guide from 10.9.1 -> 11.0.1"
- check that the doc preview is not showing the changes b/c this PR is on a fork
- add link to migration guide to the release notes here: https://github.com/microbiomedata/nmdc-schema/releases/tag/v11.0.0
- Add an over-arching summary paragraph explaining why this release bundles these changes. Maybe it's a yearly release, or maybe things were blocking the development of the submission/data portal that required a set of these changes, and additional ones were bundled as a convenience. Just a high-level summary would be very helpful.
pre_vs_berkeley.md
Outdated
| | | WorkflowExecution | | | ||
|
|
||
| For example, `MetagenomeAnnotationActivity` used to be located in the hierarchy | ||
| `Activity.WorkFlowExecutionActivity`, but now it and 11 similar classes are located in |
There was a problem hiding this comment.
I'm not familiar with this notation. Is WorkflowExecutionActivity an attribute of Activity? It reminds me of instance.attribute notation.
There was a problem hiding this comment.
A left arrow might work well as a delimiter (e.g. Parent ← Child ← Grandchild).
2190 | ← | Leftwards Arrow
-- | -- | --
| | → | 20EA ◌⃪ combining leftwards arrow overlay
There was a problem hiding this comment.
I like this but want to discuss with others. I'm adding a "Conventions" line explaining this notation for now.
|
|
||
| The leagcy `BiosampleProcessing` class (including `Pooling`, `LibraryPreparation`) and some classes that were previously | ||
| direct subclasses of `PlannedProcess` (`Extraction`, `SubSamplingProcess`, `MixingProcess`, `FiltrationProcess`, | ||
| `ChromatographicSeparationProcess`) have been re-rooted into a new `MaterialProcessing` class. |
There was a problem hiding this comment.
| `ChromatographicSeparationProcess`) have been re-rooted into a new `MaterialProcessing` class. | |
| `ChromatographicSeparationProcess`) now descend from a new class, named `MaterialProcessing`. |
There was a problem hiding this comment.
I don;t think either of the wordings we are using are really defined in the LinkML specs or in the nmdc-schema
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
Co-authored-by: eecavanna <134325062+eecavanna@users.noreply.github.com>
|
Before we do too much additional work here, can we confirm that this will move to the NMDC schema and not be accepted into this deprecated fork? |
yes, I will move it I'm working on it in the berkeley-schem-fy24 because I have my local nmdc-schema checkout on v10.9.1 so I can compare the docuemtnation |
tools and sources for documenting the legacy/10 to berkeley/11 migration and its impacts
not necessarily intended for merging. if it is going to be merged, the images should be bundled up into a directory and so on. could be merged into the origin repo.