Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make subclasses for DataGeneration #3

Merged
merged 16 commits into from
Dec 13, 2023
Merged

Conversation

aclum
Copy link
Collaborator

@aclum aclum commented Dec 12, 2023

Created DataGeneration subclasses of NucleotideSequencing and MassSpectrometry, added slots to class MassSpectrometry
Collections requiring migration:

  • omics_processing_set

Workflow code:

  • needs to be updated to

Make subclasses of DataGeneration
Update DataGenerate subclasses description and add exact mappings.
@aclum aclum linked an issue Dec 12, 2023 that may be closed by this pull request
Fix whitespace issue.
witespace debugging
Fixing exact_mapping to exact_mappings for DataGeneration subclasses
@aclum aclum requested review from brynnz22 and removed request for SamuelPurvine and turbomam December 12, 2023 20:00
@aclum aclum marked this pull request as draft December 12, 2023 20:01
Remove tandem MS subclasses, add structured_pattern slots for DataGeneration subclasses
Updates to DataGeneration subclasses, adding MassSpectrometry, updating subclass names.
New slots acquisition_category and resolution_category
Adding enumerations for MassSpectrometry slots
Fixing typo of spelling of aliases
Fixing more misspellings of aliases
updates to permissible values for AcuisitionCategoryEnum and ResolutionCategoryEnum
updates to comments for slot acquisition_category
@aclum aclum changed the base branch from 1515-global-replace-omicsprocessing-with-datageneration to main December 12, 2023 23:42
Getting rid of ms subclasses in favor of just MassSpectrometry
@aclum aclum marked this pull request as ready for review December 13, 2023 00:08
Fix spelling typo.
Copy link
Collaborator

@brynnz22 brynnz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@brynnz22 brynnz22 merged commit f49f303 into main Dec 13, 2023
2 checks passed
@brynnz22 brynnz22 deleted the 1522-DataGeneration_subclasses branch December 13, 2023 17:14
@aclum aclum added the migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. label Dec 18, 2023
@brynnz22 brynnz22 added the migrator-overhaul-needed The current migrator design is not sufficient to tackle the migration label Jan 6, 2024
@brynnz22 brynnz22 added the migrator-written a migrator script has been written addressing the PR/schema change label Mar 18, 2024
@brynnz22 brynnz22 changed the title Make subclasses for DataGeneration Make subclasses for DataGeneration Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migration-needed After applying this schema change, some valid data may become invalid. Data migration is required. migrator-overhaul-needed The current migrator design is not sufficient to tackle the migration migrator-written a migrator script has been written addressing the PR/schema change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make subclasses for DataGeneration
2 participants