forked from microbiomedata/nmdc-schema
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make subclasses for DataGeneration
#3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make subclasses of DataGeneration
Update DataGenerate subclasses description and add exact mappings.
Fix whitespace issue.
witespace debugging
Fixing exact_mapping to exact_mappings for DataGeneration subclasses
aclum
requested review from
brynnz22
and removed request for
SamuelPurvine and
turbomam
December 12, 2023 20:00
Remove tandem MS subclasses, add structured_pattern slots for DataGeneration subclasses
Updates to DataGeneration subclasses, adding MassSpectrometry, updating subclass names.
New slots acquisition_category and resolution_category
Adding enumerations for MassSpectrometry slots
Fixing typo of spelling of aliases
Fixing more misspellings of aliases
updates to permissible values for AcuisitionCategoryEnum and ResolutionCategoryEnum
updates to comments for slot acquisition_category
aclum
changed the base branch from
1515-global-replace-omicsprocessing-with-datageneration
to
main
December 12, 2023 23:42
Getting rid of ms subclasses in favor of just MassSpectrometry
Fix spelling typo.
brynnz22
approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
aclum
added
the
migration-needed
After applying this schema change, some valid data may become invalid. Data migration is required.
label
Dec 18, 2023
brynnz22
added
the
migrator-overhaul-needed
The current migrator design is not sufficient to tackle the migration
label
Jan 6, 2024
brynnz22
added
the
migrator-written
a migrator script has been written addressing the PR/schema change
label
Mar 18, 2024
brynnz22
changed the title
Make subclasses for DataGeneration
Make subclasses for Apr 19, 2024
DataGeneration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
migration-needed
After applying this schema change, some valid data may become invalid. Data migration is required.
migrator-overhaul-needed
The current migrator design is not sufficient to tackle the migration
migrator-written
a migrator script has been written addressing the PR/schema change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created DataGeneration subclasses of NucleotideSequencing and MassSpectrometry, added slots to class MassSpectrometry
Collections requiring migration:
Workflow code: