Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add slot type to nmdc planned process classes #1030

Closed
Tracked by #1466
aclum opened this issue Jul 3, 2023 · 1 comment
Closed
Tracked by #1466

Add slot type to nmdc planned process classes #1030

aclum opened this issue Jul 3, 2023 · 1 comment
Labels
closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork

Comments

@aclum
Copy link
Contributor

aclum commented Jul 3, 2023

@sujaypatil96 suggested at the metadata meeting last week that we add slot type to the new PlanndedProcess classes and ProcessedSample
-Pooling
-Extraction
-LibraryPreparation
-ProcessedSample

This will make the classes more consistent and will make it easier for API users to understand what class a json record is for.

cc @sujaypatil96 @mslarae13
@sujaypatil96 sujaypatil96 mentioned this issue Aug 15, 2023
Closed
@sujaypatil96 sujaypatil96 linked a pull request Aug 15, 2023 that will close this issue
Assert type slot on NEON classes #1066
Closed
@sujaypatil96 sujaypatil96 removed a link to a pull request Aug 15, 2023
Assert type slot on NEON classes #1066
Closed
@sujaypatil96 sujaypatil96 mentioned this issue Aug 15, 2023
Closed
@sujaypatil96 sujaypatil96 linked a pull request Aug 15, 2023 that will close this issue
type slot assertion on planned NEON process classes and processed sample #1067
Closed
This was referenced Nov 1, 2023
Closed
Open
@mslarae13 mslarae13 mentioned this issue Dec 1, 2023
Closed
63 tasks
@aclum aclum removed a link to a pull request Dec 21, 2023
type slot assertion on planned NEON process classes and processed sample #1067
Closed
@mslarae13
Copy link
Contributor

completed in the berk-schema (not applied to main). Brynn is working on a migrator. It needs update to include planned processes.

@kheal kheal added the closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork label May 22, 2024
@kheal kheal closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed_via_berkeley These issues have been addressed on the berkeley-schema-fy24 fork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aclum @kheal @mslarae13