generated from linkml/linkml-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr4 add analyte cat remove omics type migration #1616
Closed
brynnz22
wants to merge
353
commits into
microbiomedata:main
from
microbiomedata:PR4-add-analyte-cat-remove-omics-type-migration
Closed
Pr4 add analyte cat remove omics type migration #1616
brynnz22
wants to merge
353
commits into
microbiomedata:main
from
microbiomedata:PR4-add-analyte-cat-remove-omics-type-migration
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change WorkflowChain to a subclass of PlannedProcess
- make it a PlannedProcess - update description - acc comment
…crobiomedata/berkeley-schema-fy24 into 1536_add_workflow_chain_class
Fix indentation for resolution_category slot
Make exact_mappings for class MassSpectrometry a list.
Make Class:ProtocolExecution
1552 deprecate activity
Update slot name from mass_spectrum_mode to mass_spectrum_collection_mode
Updating MassSpectrumCollectionMode enumeration name to MassSpectrumCollectionModeEnum
…-that-were-on-OmicsProcessing
…ClassLibraryPrep 1540, 1541, 1543 add slots to LibraryPreparation
ues: was_informed_by analyte_category use existing AnalyteCategoryEnum
…rocessing-classes-that-were-on-OmicsProcessing 1525 add slots to material processing classes that were on omics processing
Adding class Instrument
Add instrument_used slot.
Removed slot used
fix typo in multivalued
make workflowexecutionactivity a PlannedProcess
test for reiterated inherited slots, and related cleanup
- Update model to remove incorrect, non-monotonic `multivalued: false` usage directive for the slot `part_of` - update valid models to have WorkflowExecution -- part_of --> WorkflowChain to have array data' - add 2 invalid data examples
and autoformatting it
…efinition in external_identifiers
…n' of https://github.com/microbiomedata/berkeley-schema-fy24 into 11232_add_external_analysis_identifiers_to_WorkflowChain
…lowExecution_multivalued_true Update WorkflowExecution model to remove multivalued: false slot_usage on part_of
remove slots from Biosample & DataGeneration & update examples
…s_identifiers_to_WorkflowChain Add external analysis project identifiers slots to WorkflowChain
readding omprc as a valid prefix for DataGeneration so we don't have to change the IDs of existing OmicsProcessing records just because we are changing the class name.
Add example data with 'omprc' prefix.
1581 keep omprc typecode for class Data Generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses PR: microbiomedata#4
This migration moves the values from
omics_type
to a new slot calledanalyte_category
and removes theomics_type
slot. It changes the values to match theAnalyteCategoryEnum
permissible values.