generated from linkml/linkml-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to MagsAnalysis slots #2225
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add descriptions and mappings, add enum for bin quality range.
3 tasks
@turbomam can you point me to an for setting a range to only positive integers? |
poetry doesn't like my todo statements
todos need to be a list
todo should be todos
|
Adding minimum values for MagsAnalysis slots
Adding slot description and minimum values.
turbomam
reviewed
Oct 21, 2024
turbomam
requested changes
Oct 21, 2024
Moving comments to see_also with doi for gtdb-tk slots
turbomam
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add descriptions, mappings, minimum values on slots for class MagsAnalysis. Add an enumeration as the range to bin_quality. There is not currently any data in the schema that uses these slots. There may before the November release, all that should conform to these new rules but. I will add to November release notes that workflow_execution_set should be checked with linkml-validate as part of the release process. Tagging @eecavanna @pkalita-lbl for awareness.
PR Information
What type of PR is this? (check all applicable)
class
,slot
, orenum
slot
ismultivalued
slot
is assigned to aclass
permissible_values
of anenum
class
,slot
, orenum
mappings
of aclass
,slot
, orenum
to an ontologyenum
for future use (it is not in therange
of anyslot
)Description
Related Issues
Did you add/update any tests?
Could this schema change make it so any valid data becomes invalid?
If you answered "Yes", does this PR branch include that migrator?
Does this PR have any downstream implications?