Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to MagsAnalysis slots #2225

Merged
merged 28 commits into from
Oct 28, 2024
Merged

Conversation

aclum
Copy link
Contributor

@aclum aclum commented Oct 18, 2024

Add descriptions, mappings, minimum values on slots for class MagsAnalysis. Add an enumeration as the range to bin_quality. There is not currently any data in the schema that uses these slots. There may before the November release, all that should conform to these new rules but. I will add to November release notes that workflow_execution_set should be checked with linkml-validate as part of the release process. Tagging @eecavanna @pkalita-lbl for awareness.

PR Information

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation
  • Schema change: Structure and content
    • created, updated, or deleted a class, slot, or enum
    • changed whether a slot is multivalued
    • changed the way a slot is assigned to a class
    • changed the permissible_values of an enum
    • etc.
  • Schema change: Cleanup and preparation
    • updated the description of a class, slot, or enum
    • updated the mappings of a class, slot, or enum to an ontology
    • added an enum for future use (it is not in the range of any slot)
    • etc.

Description

PRs should be small and concise.

Aim to create small, focused pull requests that fulfill a single purpose. Smaller pull requests are easier and faster to review and merge, leave less room to introduce bugs, and provide a clearer history of changes.

  • Replace this text with a description of what this PR branch contains. Please keep in mind that all reviewers will be reading this description. Example: "In this branch, I..."

Related Issues

All PRs should relate to or fix an issue(s). Please identify the issue(s) below.

Did you add/update any tests?

  • Yes
  • No (Add a justification below)
  • I need help with writing tests

Could this schema change make it so any valid data becomes invalid?

This is a question about what the schema allows. It is not a question about what happens to exists in the NMDC database right now.

Example: If, in this PR branch, you renamed a slot from foo to foo_bar, the answer to this question would be "yes," even if nothing in the NMDC database currently uses the foo slot.

More examples: slot or class name changes, changes to a slot's multivalued state, changes to a slot's range (e.g. string to integer), changes to slot assignments to classes, changes to an enum's permissible_values

  • Yes (A migrator is required)
  • No
  • I need help determining this

If you answered "Yes", does this PR branch include that migrator?

  • Yes
  • No, this PR is incomplete and I need help writing the migrator

Does this PR have any downstream implications?

Examples: any change here that requires a change to workflows, workflow automation, the Mongo-to-Postgres ingest process, Jupyter notebooks, the Runtime, etc.

  • Yes (Explain below)
  • No

Add descriptions and mappings, add enum for bin quality range.
@aclum aclum linked an issue Oct 18, 2024 that may be closed by this pull request
3 tasks
@aclum aclum requested a review from turbomam October 18, 2024 00:46
@aclum
Copy link
Contributor Author

aclum commented Oct 18, 2024

@turbomam can you point me to an for setting a range to only positive integers?

poetry doesn't like my todo statements
todos need to be a list
todo should be todos
Copy link

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2225/
on branch gh-pages at 2024-10-21 18:09 UTC

@aclum aclum marked this pull request as ready for review October 18, 2024 23:14
src/schema/core.yaml Outdated Show resolved Hide resolved
Moving comments to see_also with doi for gtdb-tk slots
@aclum aclum requested a review from turbomam October 21, 2024 18:07
@aclum aclum merged commit 5a8825f into main Oct 28, 2024
3 checks passed
@aclum aclum deleted the 2160-other-updates-to-magbin-modeling branch October 28, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Other updates to MagBin modeling
2 participants