Merge pull request #1288 from microbiomedata/issue-736

Remove extraneous data update call when changing tabs
microbiomedata · Jun 25, 2024 · e0fd91d · e0fd91d
2 parents 57b703c + 00aea5c
commit e0fd91d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/web/src/views/SubmissionPortal/HarmonizerView.vue b/web/src/views/SubmissionPortal/HarmonizerView.vue
@@ -448,8 +448,6 @@ export default defineComponent({
         return;
       }
 
-      onDataChange();
-
       await validate();
 
       // When changing templates we may need to populate the common columns
@@ -781,7 +779,7 @@ export default defineComponent({
             <v-tab>
               <v-badge
                 :content="validationTotalCounts[templateKey] || '!'"
-                :value="validationTotalCounts[templateKey] > 0 || !tabsValidated[templateKey] || status !== submissionStatus.InProgress"
+                :value="validationTotalCounts[templateKey] > 0 || !tabsValidated[templateKey]"
                 :color="validationTotalCounts[templateKey] > 0 ? 'error' : 'warning'"
               >
                 {{ HARMONIZER_TEMPLATES[templateKey].displayName }}

diff --git a/web/src/views/SubmissionPortal/store/index.ts b/web/src/views/SubmissionPortal/store/index.ts
@@ -276,6 +276,7 @@ async function incrementalSaveRecord(id: string): Promise<number | void> {
 
   if (hasChanged.value) {
     const response = await api.updateRecord(id, payload, undefined, permissions);
+    hasChanged.value = 0;
     return response.httpStatus;
   }
   hasChanged.value = 0;