Allow parsing less specific dates #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the raw value of collection date doesn't need to be changed. Our validator catches specific exceptions, but should otherwise leave the value alone.
|
Upon further investigation, the first commit to this branch breaks datetime validation for other collection dates. I'm currently investigating further |
Testing was done on production data 7/21/23 to determine patterns to check.
naglepuff
force-pushed
the
999-ingest-dates
branch
from
6a69fb8
to
703a731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, biosample collection dates without a month or year would not be ingested. This interpolates months/days as needed
Fix #999