Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-coordinate-conversion #1052

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rozek
Copy link

@rozek rozek commented Jun 27, 2021

"svelte-coordinate-conversion" converts coordinates between viewport, document and element coordinate systems (not only in Svelte)

Copy link
Contributor

@pineapplemachine pineapplemachine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update or resubmit these, please consider making one PR with each addition instead of five different PRs.

.gitignore Outdated
@@ -3,3 +3,4 @@ npm-debug.log
.DS_Store
.idea
microjs.com.iml
package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only change data.js when adding a library. Please do not change .gitignore.

tags: ["coordinate-conversions","local-coordinates","viewport-coordinates","document-coordinates"],
description: "converts coordinates between viewport, document and element coordinate systems (not only in Svelte)",
url: "https://github.com/rozek/svelte-coordinate-conversion",
source: "https://raw.githubusercontent.com/rozek/svelte-coordinate-conversion/main/src/svelte-coordinate-conversion.ts"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the readme - emphasis on "ready-to-use", which means you should not link to a TypeScript source file:

The 'source' attribute must point to a single-file, or an array of files that can be concatenated to form your complete library in a ready-to-use form. The 'source' must not be minified (see below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants