Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-determinism in Reassociate caused by address coincidences #6665

Open
wants to merge 1 commit into
base: user/zhengxing/Add-new-WeakVH-upstream
Choose a base branch
from

Conversation

lizhengxing
Copy link
Collaborator

This PR pulls the upstream change, Fix non-determinism in Reassociate caused by address coincidences (llvm/llvm-project@ef8761f), into DXC.

Here's the summary of the change:

Between building the pair map and querying it there are a few places that erase and create Values. It's rare but the address of these newly created Values is occasionally the same as a
just-erased Value that we already have in the pair map. These coincidences should be accounted for to avoid non-determinism.

Thanks to Roman Tereshin for the test case.

This is part 6 (the last part) of the fix for #6659.

This PR pulls the upstream change, Fix non-determinism in Reassociate caused by address coincidences (llvm/llvm-project@ef8761f), into DXC.

Here's the summary of the change:

  Between building the pair map and querying it there are a few places that erase and create Values. It's rare but the address of these newly created Values is occasionally the same as a
  just-erased Value that we already have in the pair map. These coincidences should be accounted for to avoid non-determinism.

  Thanks to Roman Tereshin for the test case.

This is part 6 (the last part) of the fix for #6659.
@lizhengxing lizhengxing requested a review from a team as a code owner May 31, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

1 participant