Final cleanup

microsoft · Sep 1, 2023 · e318120 · e318120
1 parent b86d60e
commit e318120
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/Microsoft.OpenApi.OData.Reader/OpenApiExtensions/OpenApiEnumFlagsExtension.cs b/src/Microsoft.OpenApi.OData.Reader/OpenApiExtensions/OpenApiEnumFlagsExtension.cs
@@ -35,10 +35,7 @@ public void Write(IOpenApiWriter writer, OpenApiSpecVersion specVersion)
 
         writer.WriteStartObject();
         writer.WriteProperty(nameof(IsFlags).ToFirstCharacterLowerCase(), IsFlags);
-        if(IsFlags)// only write style IsFlags is true 
-        {
-            writer.WriteProperty(nameof(Style).ToFirstCharacterLowerCase(),string.IsNullOrEmpty(Style) ? "form" : Style);// default to `form` 
-        }
+        writer.WriteProperty(nameof(Style).ToFirstCharacterLowerCase(),Style);
         writer.WriteEndObject();
     } 
 }
diff --git a/.../Microsoft.OpenAPI.OData.Reader.Tests/OpenApiExtensions/OpenApiEnumFlagsExtensionTests.cs b/.../Microsoft.OpenAPI.OData.Reader.Tests/OpenApiExtensions/OpenApiEnumFlagsExtensionTests.cs
@@ -63,7 +63,7 @@ public void WritesAllDefaultValues()
         Assert.True(extension.IsFlags);
         Assert.Null(extension.Style);
         Assert.Contains("\"isFlags\": true", result);
-        Assert.Contains("\"style\": \"form\"", result);// writes form for unspecified style.
+        Assert.DoesNotContain("\"style\":", result);
     }
 
     [Fact]