Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenAPI 3.1 is out!!! #552

Closed
gregsdennis opened this issue Feb 19, 2021 · 15 comments
Closed

OpenAPI 3.1 is out!!! #552

gregsdennis opened this issue Feb 19, 2021 · 15 comments
Labels
type:enhancement Enhancement request targeting an existing experience
Milestone

Comments

@gregsdennis
Copy link

The OpenAPI v3.1 spec has been released! 🎉

We want all the updates! 🎉 🎉

@darrelmiller
Copy link
Member

:-) We need to get the 1.3 milestone out and then we can focus on supporting 3.1.

We should definitely chat about how we can integrate well with whatever replaces Manatee. I also want to get System.Text.JSON support into this library. The perf difference for large documents is huge.

@gregsdennis
Copy link
Author

gregsdennis commented Feb 22, 2021

https://github.com/gregsdennis/json-everything
https://www.nuget.org/packages/JsonSchema.Net/

This is the new library suite that replaces Manatee.Json. It's fully supported by System.Text.Json. (Turns out taking my parsing/serialization logic out made things a LOT faster.)

I'm currently working on a JSON Schema extension lib that will perform the OpenAPI schema validations. I'm just waiting for the meta-schema to be released. Ideally, if it passes validation, it should just deserialize into your models without any problems.

@darrelmiller
Copy link
Member

@gregsdennis Have you seen the PR Jason Desroisier wrote? OAI/OpenAPI-Specification#2489 We reviewed it in the last TSC meeting and it is looking really close.

@darrelmiller darrelmiller added this to the 2.0 milestone Mar 14, 2021
@darrelmiller darrelmiller added the type:enhancement Enhancement request targeting an existing experience label Mar 14, 2021
@gregsdennis
Copy link
Author

Yeah, I'm part of that discussion in Slack. He's kind of our rep for right now. It's better than having 50 JSON Schema implementors yell at OAS.

@gregsdennis
Copy link
Author

So discussions over at the OAI group have yielded that the new keywords are to be annotations only (which would be pretty easy to implement). I might add in optional validation for discriminator, but I'm not sure yet.

@ygalbel
Copy link

ygalbel commented Apr 20, 2021

Hi,
We are using this library heavily.
We are working on a project that need support for Webhooks that are a part of OpenAPI 3.1.

Do you have date that you think we will be able to use it?
Thanks again for this great library

@gregsdennis
Copy link
Author

So I had a look at implementing the new keywords. Turns out OAS is saying that they're officially annotation-only, which means that there's nothing to validate. I think there's still some discussion going on regarding the meta-schema and maybe a vocabulary ID, so if anything I'd need to make an extension lib for that.

@darrelmiller I'm happy to help build in the schema support when you're ready to work on this.

@darrelmiller
Copy link
Member

Once I get the build pipeline fixed I can get this release out and start focusing on 3.1 support.

@ygalbel
Copy link

ygalbel commented May 3, 2021

Thanks a lot.

Do I have to help and push it?

@gregsdennis
Copy link
Author

Do I have to help and push it?

I think you mean, "Would it help if I got out and pushed?"

@darrelmiller
Copy link
Member

the 1.3.0-preview almost went out on Sunday night and then I discovered the Nuget API key had expired and I need someone else to fix that. Hopefully today.

@qub1n
Copy link

qub1n commented Oct 15, 2021

Guys, are you going to support OpenAPI v3.1 or not? This ticket is opened for two and half year already.

@srev-saxo
Copy link

Hi,

Do you have a rough idea about when OpenAPI 3.1 is going to be supported by OpenAPI.NET?

Thanks

@sebasptsch
Copy link

I am also eager to see when 3.1 support is going to drop.

@gregsdennis
Copy link
Author

This looks to be tracked in #795 now. I'm going to close this issue in favor of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Enhancement request targeting an existing experience
Projects
None yet
Development

No branches or pull requests

6 participants