Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model with dictionary property #834

Closed
wants to merge 1 commit into from
Closed

Conversation

darrelmiller
Copy link
Member

Added sample for scenario #62 All languages fail to render a model for the following OpenAPI

openapi: 3.0.0
info:
  title: "Dictionary API"
  version: "1.0.0"
servers:
  - url: https://example.org/
paths:
  /resource: 
    get:
      responses:
        200:
          description: ok
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/resource"
components:
  schemas:
    resource:
      type: object
      properties:
        info:
          type: string
        # customSettings: Dictionary<string,string>
        customSettings:
          type: object
          patternProperties:
            ".*":
              type: string

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@baywet baywet linked an issue Nov 15, 2021 that may be closed by this pull request
@baywet
Copy link
Member

baywet commented Nov 15, 2021

@darrelmiller Thanks for adding the test files.
I'm pondering adding a skiptest annotation for now the reasoning being: OpenApi.Net doesn't seem to have a patternProperties property on OpenAPISchema, this seems to be because the property comes from the latest additions of JSON Schema in 3.1 and the library doesn't support 3.1 yet.
Thoughts?

@baywet baywet added the documentation Improvements or additions to documentation label Jan 19, 2022
@baywet
Copy link
Member

baywet commented May 5, 2022

I believe this is superseded by #1190 closing.

@baywet baywet closed this May 5, 2022
@baywet baywet deleted the dm/dictionary-sample branch May 5, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support in models for dictionary types
2 participants