replace decimal.Parse with double.Parse to include support for parsing values exceeding range of decimal #1107

Afsalmc · 2022-12-13T16:55:58Z

fixes #1106.
Fixes #1265 as well

baywet

@Afsalmc Thanks for the contribution!
Can you make sure you sign the CLA before we proceed to merging the change?

Also, this represents a binary breaking change, so we won't be able to merge that into the current (v1) branch, we'll have to merge it to the v2 branch. I've updated the pull request target, can you operate a rebase on release/2.0.0 and force push on your end so the PR is in a clean state please?

Afsalmc · 2022-12-14T05:26:56Z

@microsoft-github-policy-service agree [company="{your company}"]
what if I'm an independent contributor?

Bumps [docker/login-action](https://github.com/docker/login-action) from 2.0.0 to 2.1.0. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v2.0.0...v2.1.0) --- updated-dependencies: - dependency-name: docker/login-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3.1.1 to 3.2.0. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@v3.1.1...v3.2.0) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps Microsoft.OData.Edm from 7.12.3 to 7.12.4. --- updated-dependencies: - dependency-name: Microsoft.OData.Edm dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Writing version field depends on current system culture version: '1.13.0' for `en-US` version: 1.13.0 for `en-GB` existing workaround: set DOTNET_SYSTEM_GLOBALIZATION_INVARIANT environment variable https://learn.microsoft.com/en-us/dotnet/core/runtime-config/globalization#invariant-mode

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 17.10.2 to 18.0.0. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@17.10.2...18.0.0) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 6.7.0 to 6.8.0. - [Release notes](https://github.com/fluentassertions/fluentassertions/releases) - [Changelog](https://github.com/fluentassertions/fluentassertions/blob/develop/AcceptApiChanges.ps1) - [Commits](fluentassertions/fluentassertions@6.7.0...6.8.0) --- updated-dependencies: - dependency-name: FluentAssertions dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps Microsoft.OData.Edm from 7.12.4 to 7.12.5. --- updated-dependencies: - dependency-name: Microsoft.OData.Edm dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Microsoft.Windows.Compatibility](https://github.com/dotnet/runtime) from 6.0.0 to 6.0.1. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v6.0.1) --- updated-dependencies: - dependency-name: Microsoft.Windows.Compatibility dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 18.0.0 to 18.1.1. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@18.0.0...18.1.1) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [coverlet.collector](https://github.com/coverlet-coverage/coverlet) from 3.1.2 to 3.2.0. - [Release notes](https://github.com/coverlet-coverage/coverlet/releases) - [Commits](https://github.com/coverlet-coverage/coverlet/commits/v3.2.0) --- updated-dependencies: - dependency-name: coverlet.collector dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 18.1.1 to 18.2.0. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@18.1.1...18.2.0) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [mathieudutour/github-tag-action](https://github.com/mathieudutour/github-tag-action) from 6.0 to 6.1. - [Release notes](https://github.com/mathieudutour/github-tag-action/releases) - [Commits](mathieudutour/github-tag-action@v6.0...v6.1) --- updated-dependencies: - dependency-name: mathieudutour/github-tag-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Verify.Xunit](https://github.com/VerifyTests/Verify) from 18.2.0 to 18.3.0. - [Release notes](https://github.com/VerifyTests/Verify/releases) - [Commits](VerifyTests/Verify@18.2.0...18.3.0) --- updated-dependencies: - dependency-name: Verify.Xunit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Microsoft.OpenApi.OData](https://github.com/Microsoft/OpenAPI.NET.OData) from 1.2.0-preview5 to 1.2.0-preview6. - [Release notes](https://github.com/Microsoft/OpenAPI.NET.OData/releases) - [Commits](https://github.com/Microsoft/OpenAPI.NET.OData/commits) --- updated-dependencies: - dependency-name: Microsoft.OpenApi.OData dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.3.2 to 17.4.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Commits](microsoft/vstest@v17.3.2...v17.4.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Microsoft.Extensions.Logging.Abstractions](https://github.com/dotnet/runtime) from 6.0.2 to 7.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/commits) --- updated-dependencies: - dependency-name: Microsoft.Extensions.Logging.Abstractions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Microsoft.Windows.Compatibility](https://github.com/dotnet/runtime) from 6.0.1 to 7.0.0. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](https://github.com/dotnet/runtime/commits) --- updated-dependencies: - dependency-name: Microsoft.Windows.Compatibility dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>

Bumps [Moq](https://github.com/moq/moq4) from 4.18.2 to 4.18.3. - [Release notes](https://github.com/moq/moq4/releases) - [Changelog](https://github.com/moq/moq4/blob/main/CHANGELOG.md) - [Commits](devlooped/moq@v4.18.2...v4.18.3) --- updated-dependencies: - dependency-name: Moq dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

…erflow due to wrong copying of AdditionalProperties object

…chema type equivalent

* Serialize OpenApiDate properly as Date * Change test date value Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail

using Microsoft.OpenApi.OData package it generates OpenApi document with OpenApiComponents.Extensions == null

…g values exceeding range of decimal

Afsalmc · 2022-12-14T06:31:28Z

@microsoft-github-policy-service agree

baywet · 2022-12-14T14:04:07Z

@microsoft-github-policy-service agree [company="{your company}"]
what if I'm an independent contributor?

I think you can ignore the company part of the message then, just mention the bot with "agree". This is new to us, it used to be a portal before they switched to a bot a couple of weeks ago.

Afsalmc · 2022-12-14T14:42:49Z

@microsoft-github-policy-service agree [company="{your company}"]
what if I'm an independent contributor?

I think you can ignore the company part of the message then, just mention the bot with "agree". This is new to us, it used to be a portal before they switched to a bot a couple of weeks ago.

Thankyou. Agreed to license agreement.

src/Microsoft.OpenApi.Readers/V3/OpenApiV3VersionService.cs

MaggieKimani1 · 2024-02-12T12:36:48Z

@Afsalmc do you mind resolving the conflicts so that we can do a merge?

MaggieKimani1 · 2024-03-13T18:10:47Z

Closing this as its superseded by #1594

Afsalmc requested review from irvinesunday, darrelmiller, peombwa, zengin, baywet, millicentachieng and MaggieKimani1 as code owners December 13, 2022 16:55

baywet changed the base branch from vnext to release/2.0.0 December 13, 2022 17:32

baywet requested changes Dec 13, 2022

View reviewed changes

dependabot bot and others added 20 commits December 14, 2022 11:18

- renames hidi in accordance to naming policy of MCR

5837b31

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

Upgrade conversion lib. ver.; update Hidi version

8774653

Remove return statement to eliminate NullReference exception

f44ef7d

dependabot bot and others added 19 commits December 14, 2022 11:55

- adds missing validation methods

cf58a23

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

- reorders public api definition

9e1a91c

Signed-off-by: Vincent Biret <vibiret@microsoft.com>

- adds coverage dependencies

992a8e7

- adds sonarcloud workflow definition

1dbcb00

- switches to windows agent because of workbench projectg

e7e3200

Fixes bug where the schema copy constructor would run into a stack ov…

f53a031

…erflow due to wrong copying of AdditionalProperties object

Add test to validate

f06e10c

Add test assertions

96f1bdc

Add OpenApiTypeMapper that maps .NET primitive types to the OpenAPI s…

93a4c1c

…chema type equivalent

Add test and update public API interface

f7ea11b

Map OpenApiSchema types to simple type and add test to validate

1d8e3ca

Update Uri format

ffa4cf8

Update type and format to lowercase

c9d790f

Fix failing tests

ad3d267

Serialize OpenApiDate values properly to short date (microsoft#1102)

32d621e

* Serialize OpenApiDate properly as Date * Change test date value Using value 01/01/0001 could be represented as 1/1/0001 in a machine using a different regional format, and thus cause the test to fail

check Extensions object for null

d624cd5

using Microsoft.OpenApi.OData package it generates OpenApi document with OpenApiComponents.Extensions == null

replace decimal.Parse with double.Parse to include support for parsin…

698f7e8

…g values exceeding range of decimal

remove unnecessary changes

f2c3f93

Afsalmc force-pushed the vnext branch from 1592710 to f2c3f93 Compare December 14, 2022 06:28

baywet approved these changes Dec 14, 2022

View reviewed changes

src/Microsoft.OpenApi.Readers/V3/OpenApiV3VersionService.cs Show resolved Hide resolved

code cleanup

9ca8d23

MaggieKimani1 mentioned this pull request Jun 14, 2023

Kiota dose not generate code for Etsy OpenAPI. #1265

Closed

Afsalmc requested a review from andrueastman as a code owner January 23, 2024 13:03

MaggieKimani1 closed this Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

replace decimal.Parse with double.Parse to include support for parsing values exceeding range of decimal #1107

replace decimal.Parse with double.Parse to include support for parsing values exceeding range of decimal #1107

Afsalmc commented Dec 13, 2022 •

edited by baywet

Loading

baywet left a comment

Afsalmc commented Dec 14, 2022

Afsalmc commented Dec 14, 2022

baywet commented Dec 14, 2022

Afsalmc commented Dec 14, 2022

MaggieKimani1 commented Feb 12, 2024 •

edited

Loading

MaggieKimani1 commented Mar 13, 2024

replace decimal.Parse with double.Parse to include support for parsing values exceeding range of decimal #1107

replace decimal.Parse with double.Parse to include support for parsing values exceeding range of decimal #1107

Conversation

Afsalmc commented Dec 13, 2022 • edited by baywet Loading

baywet left a comment

Choose a reason for hiding this comment

Afsalmc commented Dec 14, 2022

Afsalmc commented Dec 14, 2022

baywet commented Dec 14, 2022

Afsalmc commented Dec 14, 2022

MaggieKimani1 commented Feb 12, 2024 • edited Loading

MaggieKimani1 commented Mar 13, 2024

Afsalmc commented Dec 13, 2022 •

edited by baywet

Loading

MaggieKimani1 commented Feb 12, 2024 •

edited

Loading