Skip to content

MAINT: Simplifying GUI Feedback Buttons #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Richard Lundeen (rlundeen2) wants to merge 4 commits into
base: main
Choose a base branch
from
Open

MAINT: Simplifying GUI Feedback Buttons #2526

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b8226ca
MAINT: Simplifying GUI Feedback Buttons
rlundeen2 Sep 1, 2026
aea356a
MAINT: Clarify feedback submission paths
rlundeen2 Sep 1, 2026
e77bba7
MAINT: Route security reports from feedback
rlundeen2 Sep 1, 2026
06ebffe
TEST: Stabilize initializer dialog interaction
rlundeen2 Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/Configuration/Configuration.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ describe('Configuration', () => {
'C:/Users/test/.pyrit/custom_initializers/custom_target.py',
{ selector: 'label' },
)).toBeInTheDocument()
await user.click(screen.getByRole('button', { name: 'Add initializer' }))
fireEvent.click(screen.getByRole('button', { name: 'Add initializer' }))
const dialog = screen.getByRole('dialog', { name: 'Add custom initializer' })
await user.type(within(dialog).getByRole('textbox', { name: /Initializer name/ }), 'new_custom')
fireEvent.change(within(dialog).getByRole('textbox', { name: 'Python source' }), {
Expand Down
100 changes: 69 additions & 31 deletions frontend/src/components/Feedback/FeedbackDialog.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,39 +47,39 @@ describe("FeedbackDialog", () => {
});

describe("shell", () => {
it("renders sensitive-info warning and links to the public repo", () => {
it("starts without a selected feedback type or form fields", () => {
renderDialog();

expect(screen.getByText("Send feedback")).toBeInTheDocument();
const warning = screen.getByTestId("feedback-sensitive-warning");
expect(warning).toHaveTextContent(/public/i);
expect(warning).toHaveTextContent(/secrets/i);
expect(warning).toHaveTextContent(/credentials/i);
expect(warning).toHaveTextContent(/customer data/i);
expect(warning).toHaveTextContent(/proprietary/i);
expect(screen.getByRole("combobox", { name: /category/i })).toHaveValue("");
expect(
screen.getByRole("link", { name: /github\.com\/microsoft\/PyRIT/i }),
).toHaveAttribute("href", "https://github.com/microsoft/PyRIT/issues");
screen.queryByTestId("feedback-bug-describe-input"),
).not.toBeInTheDocument();
expect(
screen.getByRole("link", { name: /microsoft privacy statement/i }),
).toHaveAttribute(
"href",
"https://privacy.microsoft.com/en-us/privacystatement",
);
screen.queryByTestId("feedback-submit-button"),
).not.toBeInTheDocument();
});

it("does not render when closed", () => {
renderDialog({ open: false });
expect(screen.queryByText("Send feedback")).not.toBeInTheDocument();
});

it("offers all five template-backed categories in the dropdown", () => {
it("offers security and all five template-backed categories in the dropdown", () => {
renderDialog();
const select = screen.getByTestId(
"feedback-category-select",
) as HTMLSelectElement;
const values = Array.from(select.options).map((o) => o.value);
expect(values).toEqual(["bug", "feature", "doc", "praise", "other"]);
expect(values).toEqual([
"",
"security",
"bug",
"feature",
"doc",
"praise",
"other",
]);
});

it("calls onClose when Cancel is clicked without opening any tab", async () => {
Expand All @@ -93,8 +93,9 @@ describe("FeedbackDialog", () => {
});

describe("category-driven fields", () => {
it("defaults to the bug category and renders bug-specific fields", () => {
it("renders bug-specific fields and the public issue warning for bug reports", async () => {
renderDialog();
await pickCategory("bug");
expect(
screen.getByTestId("feedback-bug-describe-input"),
).toBeInTheDocument();
Expand All @@ -104,6 +105,42 @@ describe("FeedbackDialog", () => {
expect(
screen.getByTestId("feedback-bug-versions-input"),
).toBeInTheDocument();
expect(screen.getByTestId("feedback-sensitive-warning")).toHaveTextContent(
/public GitHub issue/i,
);
expect(
screen.getByRole("link", { name: /microsoft privacy statement/i }),
).toHaveAttribute(
"href",
"https://privacy.microsoft.com/en-us/privacystatement",
);
});

it("shows only the private reporting route for security vulnerabilities", async () => {
renderDialog();
await pickCategory("security");

expect(screen.getByTestId("feedback-security-guidance")).toHaveTextContent(
/must be reported privately/i,
);
expect(
screen.getByRole("link", { name: /PyRIT security reporting process/i }),
).toHaveAttribute(
"href",
"https://github.com/microsoft/PyRIT/security/policy",
);
expect(
screen.getByRole("link", { name: /open private reporting process/i }),
).toHaveAttribute(
"href",
"https://github.com/microsoft/PyRIT/security/policy",
);
expect(
screen.queryByTestId("feedback-submit-button"),
).not.toBeInTheDocument();
expect(
screen.queryByTestId("feedback-contact-input"),
).not.toBeInTheDocument();
});

it("swaps to feature-request fields when feature is selected", async () => {
Expand Down Expand Up @@ -152,7 +189,7 @@ describe("FeedbackDialog", () => {

it("clears prior fields when switching categories", async () => {
renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId(
"feedback-bug-describe-input",
) as HTMLTextAreaElement;
Expand Down Expand Up @@ -180,6 +217,7 @@ describe("FeedbackDialog", () => {
describe("submit gate", () => {
it("disables Continue on GitHub until the primary field reaches the minimum length", async () => {
renderDialog();
await pickCategory("bug");
const submit = screen.getByTestId("feedback-submit-button");
expect(submit).toBeDisabled();

Expand All @@ -206,7 +244,7 @@ describe("FeedbackDialog", () => {
it("submits a bug to the bug_report template with GUI + Bug: triage labels", async () => {
const onClose = jest.fn();
renderDialog({ onClose });
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste("Chat window crashes on empty send");
Expand Down Expand Up @@ -297,7 +335,7 @@ describe("FeedbackDialog", () => {

it("omits the contact section when the contact field is blank", async () => {
renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste("Some sufficiently long bug description here");
Expand All @@ -311,7 +349,7 @@ describe("FeedbackDialog", () => {

it("includes the contact section when one is provided", async () => {
renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste("Some sufficiently long bug description here");
Expand Down Expand Up @@ -345,7 +383,7 @@ describe("FeedbackDialog", () => {
describe("secret detection", () => {
it("does not show the secret warning for plain prose", async () => {
renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste("Plain feedback with no secrets at all.");
Expand All @@ -356,7 +394,7 @@ describe("FeedbackDialog", () => {

it("shows the secret warning when a token-like value appears in any field", async () => {
renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const repro = screen.getByTestId("feedback-bug-repro-input");
await user.click(repro);
await user.paste(
Expand All @@ -369,7 +407,7 @@ describe("FeedbackDialog", () => {

it("opens the confirm dialog instead of GitHub when submitting with a detected secret", async () => {
renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste(
Expand All @@ -386,7 +424,7 @@ describe("FeedbackDialog", () => {
it("cancels submission when the user clicks 'Go back and fix'", async () => {
const onClose = jest.fn();
renderDialog({ onClose });
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste(
Expand All @@ -402,7 +440,7 @@ describe("FeedbackDialog", () => {
it("proceeds to GitHub when the user explicitly clicks 'Submit anyway'", async () => {
const onClose = jest.fn();
renderDialog({ onClose });
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId("feedback-bug-describe-input");
await user.click(describe);
await user.paste(
Expand All @@ -418,7 +456,7 @@ describe("FeedbackDialog", () => {

it("resets the form when the dialog is reopened", async () => {
const { unmount } = renderDialog();
const user = userEvent.setup();
const user = await pickCategory("bug");
const describe = screen.getByTestId(
"feedback-bug-describe-input",
) as HTMLTextAreaElement;
Expand All @@ -429,9 +467,9 @@ describe("FeedbackDialog", () => {
unmount();
renderDialog();

const describeAfter = screen.getByTestId(
"feedback-bug-describe-input",
) as HTMLTextAreaElement;
expect(describeAfter.value).toBe("");
expect(screen.getByRole("combobox", { name: /category/i })).toHaveValue("");
expect(
screen.queryByTestId("feedback-bug-describe-input"),
).not.toBeInTheDocument();
});
});
Loading